cossmass/git-next
1
0
Fork 0
forked from kemitix/git-next
Code Pull requests Activity

fix: messages should always get delivered

Browse source 
Remove the async wrapper for sending messages as they were never being
delivered.
This commit is contained in:
Paul Campbell 2024-07-02 18:51:40 +01:00
parent 7fdea2913a
commit 83ce95776e
3 changed files with 5 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
crates/repo-actor/src/handlers/check_ci_status.rs
View file

@ -20,12 +20,12 @@ impl Handler<actor::messages::CheckCIStatus> for actor::RepoActor {
// get the status - pass, fail, pending (all others map to fail, e.g. error)
async move {
let status = forge.commit_status(&next).await;
let _ = actor::send(
tracing::debug!("got status: {status:?}");
actor::do_send(
addr,
actor::messages::ReceiveCIStatus::new((next, status)),
&log,
)
.await;
);
}
.in_current_span()
.into_actor(self)

5
crates/repo-actor/src/handlers/validate_repo.rs
View file

@ -87,12 +87,11 @@ impl Handler<actor::messages::ValidateRepo> for actor::RepoActor {
actor::logger(&log, "before sleep");
tokio::time::sleep(sleep_duration).await;
actor::logger(&log, "after sleep");
let _ = actor::send(
actor::do_send(
addr,
actor::messages::ValidateRepo::new(message_token),
&log,
)
.await;
);
}
.in_current_span()
.into_actor(self)

15
crates/repo-actor/src/lib.rs
View file

@ -116,21 +116,6 @@ where
_addr.do_send(msg)
}
pub async fn send<M>(
addr: Addr<RepoActor>,
msg: M,
log: &Option<crate::RepoActorLog>,
) -> std::result::Result<<M as actix::Message>::Result, actix::MailboxError>
where
M: actix::Message + Send + 'static + std::fmt::Debug,
RepoActor: actix::Handler<M>,
<M as actix::Message>::Result: Send,
{
let log_message = format!("send: {:?}", msg);
logger(log, log_message);
addr.send(msg).await
}
pub fn logger(log: &Option<crate::RepoActorLog>, message: impl Into<String>) {
if let Some(log) = log {
let message: String = message.into();