ValueTest: use val and have assertions in tests

Codacy's PMD check 'JUnit tests should include assert() or fail()'
insists on the assert being in the actual test method itself.
This commit is contained in:
Paul Campbell 2017-08-26 18:06:42 +01:00
parent 49fb39d297
commit 767b966d1a

View file

@ -1,5 +1,6 @@
package net.kemitix.conditional;
import lombok.val;
import org.junit.Test;
import static org.assertj.core.api.Assertions.assertThat;
@ -16,205 +17,196 @@ public class ValueTest {
@Test
public void valueWhereTrueIsTrue() {
//when
final String result = Value.<String>where(true).then(() -> TRUE)
val result = Value.<String>where(true).then(() -> TRUE)
.otherwise(() -> FALSE);
//then
thenIsTrue(result);
assertThat(result).isEqualTo(TRUE);
}
@Test
public void valueWhereFalseIsFalse() {
//when
final String result = Value.<String>where(false).then(() -> TRUE)
val result = Value.<String>where(false).then(() -> TRUE)
.otherwise(() -> FALSE);
//then
thenIsFalse(result);
assertThat(result).isEqualTo(FALSE);
}
@Test
public void valueWhereTrueAndTrueIsTrue() {
//when
final String result = Value.<String>where(true).and(true)
val result = Value.<String>where(true).and(true)
.then(() -> TRUE)
.otherwise(() -> FALSE);
//then
thenIsTrue(result);
assertThat(result).isEqualTo(TRUE);
}
@Test
public void valueWhereTrueAndFalseIsFalse() {
//when
final String result = Value.<String>where(true).and(false)
val result = Value.<String>where(true).and(false)
.then(() -> TRUE)
.otherwise(() -> FALSE);
//then
thenIsFalse(result);
assertThat(result).isEqualTo(FALSE);
}
@Test
public void valueWhereFalseAndTrueIsFalse() {
//when
final String result = Value.<String>where(false).and(true)
val result = Value.<String>where(false).and(true)
.then(() -> TRUE)
.otherwise(() -> FALSE);
//then
thenIsFalse(result);
assertThat(result).isEqualTo(FALSE);
}
@Test
public void valueWhereFalseAndFalseIsFalse() {
//when
final String result = Value.<String>where(false).and(false)
val result = Value.<String>where(false).and(false)
.then(() -> TRUE)
.otherwise(() -> FALSE);
//then
thenIsFalse(result);
assertThat(result).isEqualTo(FALSE);
}
@Test
public void valueWhereTrueOrTrueIsTrue() {
//when
final String result = Value.<String>where(true).or(true)
val result = Value.<String>where(true).or(true)
.then(() -> TRUE)
.otherwise(() -> FALSE);
//then
thenIsTrue(result);
assertThat(result).isEqualTo(TRUE);
}
@Test
public void valueWhereTrueOrFalseIsTrue() {
//when
final String result = Value.<String>where(true).or(false)
val result = Value.<String>where(true).or(false)
.then(() -> TRUE)
.otherwise(() -> FALSE);
//then
thenIsTrue(result);
assertThat(result).isEqualTo(TRUE);
}
@Test
public void valueWhereFalseOrTrueIsTrue() {
//when
final String result = Value.<String>where(false).or(true)
val result = Value.<String>where(false).or(true)
.then(() -> TRUE)
.otherwise(() -> FALSE);
//then
thenIsTrue(result);
assertThat(result).isEqualTo(TRUE);
}
@Test
public void valueWhereFalseOrFalseIsFalse() {
//when
final String result = Value.<String>where(false).or(false)
val result = Value.<String>where(false).or(false)
.then(() -> TRUE)
.otherwise(() -> FALSE);
//then
thenIsFalse(result);
assertThat(result).isEqualTo(FALSE);
}
@Test
public void valueWhereNotTrueIsFalse() {
//when
final String result = Value.<String>whereNot(true).then(() -> TRUE)
val result = Value.<String>whereNot(true).then(() -> TRUE)
.otherwise(() -> FALSE);
//then
thenIsFalse(result);
assertThat(result).isEqualTo(FALSE);
}
@Test
public void valueWhereNotFalseIsTrue() {
//when
final String result = Value.<String>whereNot(false).then(() -> TRUE)
val result = Value.<String>whereNot(false).then(() -> TRUE)
.otherwise(() -> FALSE);
//then
thenIsTrue(result);
assertThat(result).isEqualTo(TRUE);
}
@Test
public void valueWhereTrueAndNotTrueIsFalse() {
//when
final String result = Value.<String>where(true).andNot(true)
val result = Value.<String>where(true).andNot(true)
.then(() -> TRUE)
.otherwise(() -> FALSE);
//then
thenIsFalse(result);
assertThat(result).isEqualTo(FALSE);
}
@Test
public void valueWhereTrueAndNotFalseIsTrue() {
//when
final String result = Value.<String>where(true).andNot(false)
val result = Value.<String>where(true).andNot(false)
.then(() -> TRUE)
.otherwise(() -> FALSE);
//then
thenIsTrue(result);
assertThat(result).isEqualTo(TRUE);
}
@Test
public void valueWhereFalseAndNotTrueIsFalse() {
//when
final String result = Value.<String>where(false).andNot(true)
val result = Value.<String>where(false).andNot(true)
.then(() -> TRUE)
.otherwise(() -> FALSE);
//then
thenIsFalse(result);
assertThat(result).isEqualTo(FALSE);
}
@Test
public void valueWhereFalseAndNotFalseIsFalse() {
//when
final String result = Value.<String>where(false).andNot(false)
val result = Value.<String>where(false).andNot(false)
.then(() -> TRUE)
.otherwise(() -> FALSE);
//then
thenIsFalse(result);
assertThat(result).isEqualTo(FALSE);
}
@Test
public void valueWhereTrueOrNotTrueIsTrue() {
//when
final String result = Value.<String>where(true).orNot(true)
val result = Value.<String>where(true).orNot(true)
.then(() -> TRUE)
.otherwise(() -> FALSE);
//then
thenIsTrue(result);
assertThat(result).isEqualTo(TRUE);
}
@Test
public void valueWhereTrueOrNotFalseIsTrue() {
//when
final String result = Value.<String>where(true).orNot(false)
val result = Value.<String>where(true).orNot(false)
.then(() -> TRUE)
.otherwise(() -> FALSE);
//then
thenIsTrue(result);
assertThat(result).isEqualTo(TRUE);
}
@Test
public void valueWhereFalseOrNotTrueIsFalse() {
//when
final String result = Value.<String>where(false).orNot(true)
val result = Value.<String>where(false).orNot(true)
.then(() -> TRUE)
.otherwise(() -> FALSE);
//then
thenIsFalse(result);
assertThat(result).isEqualTo(FALSE);
}
@Test
public void valueWhereFalseOrNotFalseIsTrue() {
//when
final String result = Value.<String>where(false).orNot(false)
val result = Value.<String>where(false).orNot(false)
.then(() -> TRUE)
.otherwise(() -> FALSE);
//then
thenIsTrue(result);
}
private void thenIsFalse(final String result) {
assertThat(result).isEqualTo(FALSE);
}
private void thenIsTrue(final String result) {
assertThat(result).isEqualTo(TRUE);
}
}