refactor: extract alerts into own actor

crates/cli/src/alerts/desktop.rs

@@ -1,5 +1,5 @@
 //
-use crate::{repo::messages::NotifyUser, server::actor::handlers::notify_user::short_message};
+use crate::alerts::{messages::NotifyUser, short_message};
 
 pub(super) fn send_desktop_notification(msg: &NotifyUser) {
     let message = short_message(msg);

crates/cli/src/alerts/email.rs

@@ -1,9 +1,7 @@
 //
 use git_next_core::server::{EmailConfig, SmtpConfig};
 
-use crate::repo::messages::NotifyUser;
+use crate::alerts::{full_message, messages::NotifyUser, short_message};
-
-use super::{full_message, short_message};
 
 #[derive(Debug)]
 struct EmailMessage {

crates/cli/src/alerts/handlers/mod.rs

@@ -0,0 +1,2 @@
+mod notify_user;
+mod update_shout;

crates/cli/src/alerts/handlers/notify_user.rs

@@ -0,0 +1,36 @@
+//
+use actix::prelude::*;
+use tracing::{info, instrument, Instrument as _};
+
+use crate::alerts::{
+    desktop::send_desktop_notification, email::send_email, messages::NotifyUser,
+    webhook::send_webhook, AlertsActor,
+};
+
+impl Handler<NotifyUser> for AlertsActor {
+    type Result = ();
+
+    #[instrument]
+    fn handle(&mut self, msg: NotifyUser, ctx: &mut Self::Context) -> Self::Result {
+        let Some(shout) = &self.shout else {
+            info!("No shout config available");
+            return;
+        };
+        let net = self.net.clone();
+        let shout = shout.clone();
+        async move {
+            if let Some(webhook_config) = shout.webhook() {
+                send_webhook(&msg, webhook_config, &net).await;
+            }
+            if let Some(email_config) = shout.email() {
+                send_email(&msg, email_config);
+            }
+            if shout.desktop() {
+                send_desktop_notification(&msg);
+            }
+        }
+        .in_current_span()
+        .into_actor(self)
+        .wait(ctx);
+    }
+}

crates/cli/src/alerts/handlers/update_shout.rs

@@ -0,0 +1,12 @@
+//
+use actix::prelude::*;
+
+use crate::alerts::{messages::UpdateShout, AlertsActor};
+
+impl Handler<UpdateShout> for AlertsActor {
+    type Result = ();
+
+    fn handle(&mut self, msg: UpdateShout, _ctx: &mut Self::Context) -> Self::Result {
+        self.shout.replace(msg.unwrap());
+    }
+}

crates/cli/src/alerts/history.rs

@@ -0,0 +1,2 @@
+#[derive(Debug, Default)]
+pub struct History {}

crates/cli/src/alerts/messages.rs

@@ -0,0 +1,86 @@
+//
+use derive_more::Deref as _;
+use git_next_core::{git::UserNotification, message, server::Shout};
+use serde_json::json;
+
+message!(UpdateShout: Shout: "Updated Shout configuration");
+
+message!(NotifyUser: UserNotification: "Request to send the message payload to the notification webhook");
+impl NotifyUser {
+    pub fn as_json(&self, timestamp: time::OffsetDateTime) -> serde_json::Value {
+        let timestamp = timestamp.unix_timestamp().to_string();
+        match self.deref() {
+            UserNotification::CICheckFailed {
+                forge_alias,
+                repo_alias,
+                commit,
+            } => json!({
+                "type": "cicheck.failed",
+                "timestamp": timestamp,
+                "data": {
+                    "forge_alias": forge_alias,
+                    "repo_alias": repo_alias,
+                    "commit": {
+                        "sha": commit.sha(),
+                        "message": commit.message()
+                    }
+                }
+            }),
+            UserNotification::RepoConfigLoadFailure {
+                forge_alias,
+                repo_alias,
+                reason,
+            } => json!({
+                "type": "config.load.failed",
+                "timestamp": timestamp,
+                "data": {
+                    "forge_alias": forge_alias,
+                    "repo_alias": repo_alias,
+                    "reason": reason
+                }
+            }),
+            UserNotification::WebhookRegistration {
+                forge_alias,
+                repo_alias,
+                reason,
+            } => json!({
+                "type": "webhook.registration.failed",
+                "timestamp": timestamp,
+                "data": {
+                    "forge_alias": forge_alias,
+                    "repo_alias": repo_alias,
+                    "reason": reason
+                }
+            }),
+            UserNotification::DevNotBasedOnMain {
+                forge_alias,
+                repo_alias,
+                dev_branch,
+                main_branch,
+                dev_commit,
+                main_commit,
+            } => json!({
+                "type": "branch.dev.not-on-main",
+                "timestamp": timestamp,
+                "data": {
+                    "forge_alias": forge_alias,
+                    "repo_alias": repo_alias,
+                    "branches": {
+                        "dev": dev_branch,
+                        "main": main_branch
+                    },
+                    "commits": {
+                        "dev": {
+                            "sha": dev_commit.sha(),
+                            "message": dev_commit.message()
+                        },
+                        "main": {
+                            "sha": main_commit.sha(),
+                            "message": main_commit.message()
+                        }
+                    }
+                }
+            }),
+        }
+    }
+}

crates/cli/src/alerts/mod.rs

@@ -1,44 +1,32 @@
-//
-mod desktop;
-mod email;
-mod webhook;
-
 use std::ops::Deref as _;
 
+//
 use actix::prelude::*;
 
-use desktop::send_desktop_notification;
+use derive_more::derive::Constructor;
-use email::send_email;
-use git_next_core::git::UserNotification;
-use tracing::Instrument;
-use webhook::send_webhook;
 
-use crate::{repo::messages::NotifyUser, server::actor::ServerActor};
+use git_next_core::{git::UserNotification, server::Shout};
 
-impl Handler<NotifyUser> for ServerActor {
+pub use history::History;
-    type Result = ();
+use messages::NotifyUser;
 
-    fn handle(&mut self, msg: NotifyUser, ctx: &mut Self::Context) -> Self::Result {
+mod desktop;
-        let Some(server_config) = &self.server_config else {
+mod email;
-            return;
+mod handlers;
-        };
+mod history;
-        let shout_config = server_config.shout().clone();
+pub mod messages;
-        let net = self.net.clone();
+mod webhook;
-        async move {
+
-            if let Some(webhook_config) = shout_config.webhook() {
+#[derive(Debug, Constructor)]
-                send_webhook(&msg, webhook_config, &net).await;
+pub struct AlertsActor {
-            }
+    shout: Option<Shout>, // config for sending alerts to users
-            if let Some(email_config) = shout_config.email() {
+    #[allow(dead_code)] // TODO (#128) Prevent duplicate user notifications
-                send_email(&msg, email_config);
+    history: History, // record of alerts sent recently (e.g. 24 hours)
-            }
+    net: kxio::network::Network,
-            if shout_config.desktop() {
-                send_desktop_notification(&msg);
-            }
-        }
-        .in_current_span()
-        .into_actor(self)
-        .wait(ctx);
 }
+
+impl Actor for AlertsActor {
+    type Context = Context<Self>;
 }
 
 fn short_message(msg: &NotifyUser) -> String {

crates/cli/src/alerts/webhook.rs

@@ -3,7 +3,7 @@ use git_next_core::server::OutboundWebhook;
 use secrecy::ExposeSecret as _;
 use standardwebhooks::Webhook;
 
-use crate::repo::messages::NotifyUser;
+use crate::alerts::messages::NotifyUser;
 
 pub(super) async fn send_webhook(
     msg: &NotifyUser,

crates/cli/src/main.rs

@@ -1,4 +1,5 @@
 //
+mod alerts;
 mod file_watcher;
 mod forge;
 mod init;

crates/cli/src/repo/mod.rs

@@ -1,9 +1,9 @@
 //
 use actix::prelude::*;
 
+use crate::alerts::messages::NotifyUser;
 use derive_more::Deref;
 use kxio::network::Network;
-use messages::NotifyUser;
 use std::time::Duration;
 use tracing::{info, warn, Instrument};
 

crates/cli/src/server/actor/handlers/mod.rs

@@ -1,5 +1,4 @@
 mod file_updated;
-mod notify_user;
 mod receive_server_config;
 mod receive_valid_server_config;
 mod shutdown;

crates/cli/src/server/actor/handlers/receive_valid_server_config.rs

@@ -4,6 +4,7 @@ use actix::prelude::*;
 use tracing::info;
 
 use crate::{
+    alerts::messages::UpdateShout,
     server::actor::{
         messages::{ReceiveValidServerConfig, ValidServerConfig},
         ServerActor,
@@ -18,7 +19,7 @@ use crate::{
 impl Handler<ReceiveValidServerConfig> for ServerActor {
     type Result = ();
 
-    fn handle(&mut self, msg: ReceiveValidServerConfig, ctx: &mut Self::Context) -> Self::Result {
+    fn handle(&mut self, msg: ReceiveValidServerConfig, _ctx: &mut Self::Context) -> Self::Result {
         let ValidServerConfig {
             server_config,
             socket_address,
@@ -33,6 +34,7 @@ impl Handler<ReceiveValidServerConfig> for ServerActor {
         info!("Starting Webhook Server...");
         let webhook_router = WebhookRouter::default().start();
         let listen_url = server_config.listen().url();
+        let alerts = self.alerts.clone();
         // Forge Actors
         for (forge_alias, forge_config) in server_config.forges() {
             let repo_actors = self
@@ -41,7 +43,7 @@ impl Handler<ReceiveValidServerConfig> for ServerActor {
                     forge_alias.clone(),
                     &server_storage,
                     listen_url,
-                    ctx.address().recipient(),
+                    alerts.clone().recipient(),
                 )
                 .into_iter()
                 .map(|a| self.start_actor(a))
@@ -64,6 +66,8 @@ impl Handler<ReceiveValidServerConfig> for ServerActor {
         let webhook_actor_addr =
             WebhookActor::new(socket_address, webhook_router.recipient()).start();
         self.webhook_actor_addr.replace(webhook_actor_addr);
+        let shout = server_config.shout().clone();
         self.server_config.replace(server_config);
+        self.alerts.do_send(UpdateShout::new(shout));
     }
 }

crates/cli/src/server/actor/mod.rs

@@ -10,11 +10,10 @@ mod handlers;
 pub mod messages;
 
 use crate::{
+    alerts::messages::NotifyUser,
+    alerts::AlertsActor,
     forge::Forge,
-    repo::{
+    repo::{messages::CloneRepo, RepoActor},
-        messages::{CloneRepo, NotifyUser},
-        RepoActor,
-    },
     webhook::WebhookActor,
 };
 
@@ -56,6 +55,7 @@ pub struct ServerActor {
     webhook_actor_addr: Option<Addr<WebhookActor>>,
     fs: FileSystem,
     net: Network,
+    alerts: Addr<AlertsActor>,
     repository_factory: Box<dyn RepositoryFactory>,
     sleep_duration: std::time::Duration,
     repo_actors: BTreeMap<(ForgeAlias, RepoAlias), Addr<RepoActor>>,
@@ -71,6 +71,7 @@ impl ServerActor {
     pub fn new(
         fs: FileSystem,
         net: Network,
+        alerts: Addr<AlertsActor>,
         repo: Box<dyn RepositoryFactory>,
         sleep_duration: std::time::Duration,
     ) -> Self {
@@ -81,6 +82,7 @@ impl ServerActor {
             webhook_actor_addr: None,
             fs,
             net,
+            alerts,
             repository_factory: repo,
             sleep_duration,
             repo_actors: BTreeMap::new(),

crates/cli/src/server/actor/tests/given.rs

@@ -1,3 +1,8 @@
+use actix::prelude::*;
+
+use crate::alerts::{AlertsActor, History};
+
+//
 pub fn a_filesystem() -> kxio::fs::FileSystem {
     kxio::fs::temp().unwrap_or_else(|e| panic!("{}", e))
 }
@@ -5,3 +10,7 @@ pub fn a_filesystem() -> kxio::fs::FileSystem {
 pub fn a_network() -> kxio::network::MockNetwork {
     kxio::network::MockNetwork::new()
 }
+
+pub fn an_alerts_actor(net: kxio::network::Network) -> Addr<AlertsActor> {
+    AlertsActor::new(None, History::default(), net).start()
+}

crates/cli/src/server/actor/tests/receive_server_config.rs

@@ -18,11 +18,12 @@ async fn when_webhook_url_has_trailing_slash_should_not_send() {
     // parameters
     let fs = given::a_filesystem();
     let net = given::a_network();
+    let alerts = given::an_alerts_actor(net.clone().into());
     let repo = git::repository::factory::mock();
     let duration = std::time::Duration::from_millis(1);
 
     // sut
-    let server = ServerActor::new(fs.clone(), net.into(), repo, duration);
+    let server = ServerActor::new(fs.clone(), net.into(), alerts, repo, duration);
 
     // collaborators
     let listen = Listen::new(

crates/cli/src/server/mod.rs

@@ -6,7 +6,10 @@ mod tests;
 
 use actix::prelude::*;
 
-use crate::file_watcher::{watch_file, FileUpdated};
+use crate::{
+    alerts::{AlertsActor, History},
+    file_watcher::{watch_file, FileUpdated},
+};
 use actor::ServerActor;
 use git_next_core::git::RepositoryFactory;
 
@@ -41,8 +44,18 @@ pub fn start(
     init_logging();
 
     let execution = async move {
+        info!("Starting Alert Dispatcher...");
+        let alerts_addr = AlertsActor::new(None, History::default(), net.clone()).start();
+
         info!("Starting Server...");
-        let server = ServerActor::new(fs.clone(), net.clone(), repo, sleep_duration).start();
+        let server = ServerActor::new(
+            fs.clone(),
+            net.clone(),
+            alerts_addr.clone(),
+            repo,
+            sleep_duration,
+        )
+        .start();
         server.do_send(FileUpdated);
 
         info!("Starting File Watcher...");