kemitix/git-next
1
1
Fork 1
Code Issues 18 Pull requests 1 Projects 1 Releases 41 Packages 2 Wiki Activity Actions

WIP: add FIXME notes for commit_log
All checks were successful
ci/woodpecker/push/push-next Pipeline was successful
Details
ci/woodpecker/push/cron-docker-builder Pipeline was successful
Details
ci/woodpecker/push/tag-created Pipeline was successful
Details

Browse source
This commit is contained in:
Paul Campbell 2024-05-25 11:29:08 +01:00
parent a259fd3552
commit cde9531150
2 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
crates/forge-forgejo/src/branch/validate_positions.rs
View file

@ -204,6 +204,8 @@ async fn get_commit_history(
info!("new version matches"); info!("new version matches");
Ok(updated) Ok(updated)
} else { } else {
// FIXME: log original and updated on seperate log lines - can't find where one ends and
// the other beings!
error!(?updated, ?original, "new version doesn't match original"); error!(?updated, ?original, "new version doesn't match original");
Ok(original) Ok(original)
} }

1
crates/git/src/repository/open/oreal.rs
View file

@ -111,6 +111,7 @@ impl super::OpenRepositoryLike for RealOpenRepository {
branch_name: &config::BranchName, branch_name: &config::BranchName,
find_commits: &[git::Commit], find_commits: &[git::Commit],
) -> Result<Vec<crate::Commit>, git::commit::log::Error> { ) -> Result<Vec<crate::Commit>, git::commit::log::Error> {
// FIXME: only finds 'main', does it need to prefix branch_name with 'origin/'?
self.0 self.0
.lock() .lock()
.map_err(|_| git::commit::log::Error::Lock) .map_err(|_| git::commit::log::Error::Lock)