kemitix/git-next

Allow any user supplied value as notification.webhook.secret #118

New issue

Closed

opened 2024-07-29 07:48:10 +01:00 by kemitix · 0 comments

kemitix commented

2024-07-29 07:48:10 +01:00

Owner

Not all notification.webhook.secret values are valid as far as standardwebhooks is concerned. A quick look at their source, they appear to try to parse the value with a base64 decoder. Should we be conding it before passing to it standardwebhooks?

Not all `notification.webhook.secret` values are valid as far as `standardwebhooks` is concerned. A quick look at their source, they appear to try to parse the value with a base64 decoder. Should we be conding it before passing to it `standardwebhooks`?

kemitix added this to the NEXT-RELEASE milestone 2024-07-29 07:48:10 +01:00

kemitix added the

label 2024-07-29 07:48:10 +01:00

kemitix self-assigned this 2024-07-29 07:48:10 +01:00

kemitix added this to the Road to v1 - Forgejo & Github project 2024-07-29 07:48:10 +01:00

kemitix referenced this issue from a commit

2024-07-29 08:19:23 +01:00

fix: webhook secret doesn't need to be base64 encoded

kemitix closed this issue

2024-07-29 08:21:06 +01:00

kemitix modified the milestone from NEXT-RELEASE to v0.12.1

2024-07-29 20:13:07 +01:00

Sign in to join this conversation.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: kemitix/git-next#118

No description provided.