kemitix/git-next

Perform a controlled shutdown when receive Ctrl-C #94

New issue

Closed

opened 2024-06-16 12:14:01 +01:00 by kemitix · 0 comments

kemitix commented

2024-06-16 12:14:01 +01:00

Owner

Server and File Watcher are currently being dropped when we get the Ctrl-C, and no shutdown occurs. This is primarly causing a zombie webhook registration to be left in place against each monitored repository that is only removed when the server next restarts, assuming it is monitoring the same repositories and using the same webhook URL.

When the Ctrl-C signal is received these webhooks should be explicitly unregistered before the process terminates.

Server and File Watcher are currently being dropped when we get the Ctrl-C, and no shutdown occurs. This is primarly causing a zombie webhook registration to be left in place against each monitored repository that is only removed when the server next restarts, assuming it is monitoring the same repositories and using the same webhook URL. When the Ctrl-C signal is received these webhooks should be explicitly unregistered before the process terminates.

kemitix added this to the Road to v1 - Forgejo & Github project 2024-06-16 12:14:01 +01:00

kemitix referenced this issue from a commit

2024-07-11 19:17:36 +01:00

feat: perform controlled shutdown on ctrl-c

kemitix referenced this issue from a commit

2024-07-11 19:19:18 +01:00

feat: perform controlled shutdown on ctrl-c

kemitix closed this issue

2024-07-11 19:47:27 +01:00

Sign in to join this conversation.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: kemitix/git-next#94

No description provided.