From 4727f4faa512eb76621fb1254249493e18b52f62 Mon Sep 17 00:00:00 2001 From: Paul Campbell Date: Fri, 9 Sep 2016 20:56:37 +0100 Subject: [PATCH] RequireThis: enabled --- README.md | 12 +++++------- src/main/resources/net/kemitix/checkstyle.xml | 3 +++ 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/README.md b/README.md index 2db588f..c0513c1 100644 --- a/README.md +++ b/README.md @@ -240,7 +240,7 @@ You need to include `checkstyle` as the version bundled with the `maven-checksty * [RegexpSingleline](#regexpsingleline) - checkstyle - disabled * [RegexpSinglelineJava](#regexpsinglelinejava) - checkstyle - disabled * [RequiredParameterForAnnotation](#requiredparameterforannotation) - sevntu - disabled -* [RequireThis](#requirethis) - checkstyle - disabled +* [RequireThis](#requirethis) - checkstyle - enabled * [ReturnBooleanFromTernary](#returnbooleanfromternary) - sevntu - enabled * [ReturnCount](#returncount) - checkstyle - enabled * [ReturnCountExtended](#returncountextended) - sevntu - disabled @@ -1840,6 +1840,10 @@ Checks for redundant modifiers. Checks for: * Class constructors. * Nested enum definitions that are declared as static. +#### [RequireThis](http://checkstyle.sourceforge.net/config_coding.html#RequireThis) + +Checks that references to instance fields where a parameter name overlaps are qualified by `this.`. + #### [ReturnCount](http://checkstyle.sourceforge.net/config_coding.html#ReturnCount) Restricts methods to have at most 2 `return` statements in non-void methods, and at most 1 in void methods. @@ -2766,12 +2770,6 @@ Generic rule; doesn't embody a 'quality' check. Generic rule; doesn't embody a 'quality' check. -#### [RequireThis](http://checkstyle.sourceforge.net/config_coding.html#RequireThis) - -> TODO: enable - -> TODO: checkMethods = false - #### [SingleLineJavadoc](http://checkstyle.sourceforge.net/config_javadoc.html#SingleLineJavadoc) I don't use single line javadoc blocks. diff --git a/src/main/resources/net/kemitix/checkstyle.xml b/src/main/resources/net/kemitix/checkstyle.xml index 9984251..9a2273d 100644 --- a/src/main/resources/net/kemitix/checkstyle.xml +++ b/src/main/resources/net/kemitix/checkstyle.xml @@ -190,6 +190,9 @@ + + +