Mark regressions to run with checkstyle disbled for normal builds

Enable checkstyle when checking that regressions are being caught.
This commit is contained in:
Paul Campbell 2018-01-05 22:21:19 +00:00
parent 87358bfe92
commit 97d0cef4e7
7 changed files with 3 additions and 11 deletions

View file

@ -13,7 +13,7 @@
<name>Kemitix Checkstyle :: Ruleset :: Regression Tests</name> <name>Kemitix Checkstyle :: Ruleset :: Regression Tests</name>
<properties> <properties>
<kemitix-checkstyle-ruleset.version>${project.version}</kemitix-checkstyle-ruleset.version> <!-- use the disabled ruleset for normal builds. comment out the following line to check that conditions are caught -->
<ruleset.level>0-disabled</ruleset.level> <ruleset.level>0-disabled</ruleset.level>
<digraph-dependency.basePackage>net.kemitix.checkstyle.regressions</digraph-dependency.basePackage> <digraph-dependency.basePackage>net.kemitix.checkstyle.regressions</digraph-dependency.basePackage>
<pitest.skip>true</pitest.skip> <pitest.skip>true</pitest.skip>
@ -29,7 +29,6 @@
</dependency> </dependency>
</dependencies> </dependencies>
<build> <build>
<plugins> <plugins>
<plugin> <plugin>

View file

@ -33,7 +33,6 @@ public class AvoidDefaultSerializableInInnerClasses {
/** /**
* Inner class should not use default implementations of {@code readObject()} and {@code writeObject()}. * Inner class should not use default implementations of {@code readObject()} and {@code writeObject()}.
*/ */
@SuppressWarnings("avoiddefaultserializableininnerclasses")
public class InnerClass implements Serializable { public class InnerClass implements Serializable {
} }

View file

@ -22,7 +22,7 @@
package net.kemitix.checkstyle.regressions; package net.kemitix.checkstyle.regressions;
/** /**
* Sample class. * Sample class with no checkstyle issues.
* *
* @author Paul Campbell (pcampbell@kemitix.net) * @author Paul Campbell (pcampbell@kemitix.net)
*/ */

View file

@ -31,7 +31,6 @@ public class EmptyPublicCtorInClass {
/** /**
* Useless empty public constructors. * Useless empty public constructors.
*/ */
@SuppressWarnings("emptypublicctorinclass")
EmptyPublicCtorInClass() { EmptyPublicCtorInClass() {
} }

View file

@ -37,16 +37,12 @@ class ExplicitInitialization {
private Object validObject = new Object(); private Object validObject = new Object();
@SuppressWarnings("explicitinitialization")
private Boolean invalidBoolean = null; private Boolean invalidBoolean = null;
@SuppressWarnings("explicitinitialization")
private Integer invalidInteger = null; private Integer invalidInteger = null;
@SuppressWarnings("explicitinitialization")
private String invalidString = null; private String invalidString = null;
@SuppressWarnings("explicitinitialization")
private Object invalidObject = null; private Object invalidObject = null;
} }

View file

@ -31,7 +31,7 @@ class FinalizeImplementation {
/** /**
* Negates effect of superclass finalize. * Negates effect of superclass finalize.
*/ */
@SuppressWarnings({"PMD.EmptyFinalizer", "nofinalizer", "finalizeimplementation"}) @SuppressWarnings("PMD.EmptyFinalizer")
protected void finalize() { protected void finalize() {
// doesn't call super.finalize() // doesn't call super.finalize()
} }

View file

@ -41,7 +41,6 @@ class MoveVariableInsideIf {
* *
* @return value * @return value
*/ */
@SuppressWarnings("movevariableinsideif")
protected String invalid() { protected String invalid() {
String variable = input.substring(1); String variable = input.substring(1);
if (condition) { if (condition) {