diff --git a/CHANGELOG b/CHANGELOG index c74deb4..ef8fa5e 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,6 +1,21 @@ CHANGELOG ========= +3.3.0 +----- + +* Upgrade spring boot to 1.5.4 +* Upgrade platform to Brussels-SR3 +* Upgrade checkstyle to 8.0 +* Upgrade immutables to 2.5.6 +* Upgrade mockito to 2.8.47 +* Upgrade sevntu to 1.24.1 +* Enable rule: EmptyPublicCtorInClass +* Enable rule: WhiteSpaceBeforeArrayInitializer +* Enable rule: FinalizeImplementation +* Enable rule: AvoidDefaultSerializableInInnerClass + + 3.2.0 ----- diff --git a/README.md b/README.md index a58651e..1475469 100644 --- a/README.md +++ b/README.md @@ -83,7 +83,7 @@ Rule|Level|Source|Enabled|Suppressible [AtclauseOrder](#atclauseorder)|javadoc|checkstyle|Yes| [AvoidConditionInversion](#avoidconditioninversion)|complexity|sevntu|| [AvoidConstantAsFirstOperandInCondition](#avoidconstantasfirstoperandincondition)|tweaks|sevntu|Yes| -[AvoidDefaultSerializableInInnerClasses](#avoiddefaultserializableininnerclasses)|complexity|sevntu|| +[AvoidDefaultSerializableInInnerClasses](#avoiddefaultserializableininnerclasses)|tweaks|sevntu|Yes| [AvoidEscapedUnicodeCharacters](#avoidescapedunicodecharacters)|tweaks|checkstyle|Yes| [AvoidHidingCauseException](#avoidhidingcauseexception)|tweaks|sevntu|Yes| [AvoidInlineConditionals](#avoidinlineconditionals)|complexity|checkstyle|Yes| @@ -116,7 +116,7 @@ Rule|Level|Source|Enabled|Suppressible [EmptyForInitializerPad](#emptyforinitializerpad)|layout|checkstyle|Yes| [EmptyForIteratorPad](#emptyforiteratorpad)|layout|checkstyle|Yes| [EmptyLineSeparator](#emptylineseparator)|layout|checkstyle|Yes| -[EmptyPublicCtorInClass](#emptypublicctorinclass)|tweaks|sevntu|| +[EmptyPublicCtorInClass](#emptypublicctorinclass)|tweaks|sevntu|Yes| [EmptyStatement](#emptystatement)|layout|checkstyle|Yes| [EnumValueName](#enumvaluename)|naming|sevntu|Yes| [EqualsAvoidNull](#equalsavoidnull)|tweaks|checkstyle|Yes| @@ -127,7 +127,7 @@ Rule|Level|Source|Enabled|Suppressible [FileLength](#filelength)|complexity|checkstyle|Yes| [FileTabCharacter](#filetabcharacter)|layout|checkstyle|Yes| [FinalClass](#finalclass)|complexity|checkstyle|Yes| -[FinalizeImplementation](#finalizeimplementation)|unspecified|sevntu|| +[FinalizeImplementation](#finalizeimplementation)|tweaks|sevntu|Yes| [FinalLocalVariable](#finallocalvariable)|tweaks|checkstyle|| [FinalParameters](#finalparameters)|tweaks|checkstyle|Yes| [ForbidAnnotation](#forbidannotation)|unspecified|sevntu|| @@ -268,7 +268,7 @@ Rule|Level|Source|Enabled|Suppressible [VisibilityModifier](#visibilitymodifier)|tweaks|checkstyle|Yes|No [WhitespaceAfter](#whitespaceafter)|layout|checkstyle|Yes| [WhitespaceAround](#whitespacearound)|layout|checkstyle|Yes| -[WhitespaceBeforeArrayInitializer](#whitespacebeforearrayinitializer)|layout|sevntu|| +[WhitespaceBeforeArrayInitializer](#whitespacebeforearrayinitializer)|layout|sevntu|Yes| [WriteTag](#writetag)|unspecified|checkstyle|| ## Enabled Checks @@ -2182,6 +2182,9 @@ Invalid: ```` if (12 == a) {} ```` +#### [AvoidDefaultSerializableInInnerClasses](http://sevntu-checkstyle.github.io/sevntu.checkstyle/apidocs/com/github/sevntu/checkstyle/checks/coding/AvoidDefaultSerializableInInnerClassesCheck.html) + +Prevent the use of default serialization methods on inner classes. If an inner class needs to implement the Serializable interface, then it *must* implement both `writeObject()` and `readObject()` methods. #### [AvoidHidingCauseException](http://sevntu-checkstyle.github.io/sevntu.checkstyle/apidocs/com/github/sevntu/checkstyle/checks/coding/AvoidHidingCauseExceptionCheck.html) Ensures that an exception is re-thrown properly and is not swallowed by a `catch` block. @@ -2258,6 +2261,32 @@ Map idTable = new HashMap(); Checks that when an exception is caught, that if it is logged then it is not also re-thrown. Log or throw; one or the other or neither, but not both. Accepts `java.util.logging.Logger` and `org.slf4j.Logger`. +#### [EmptyPublicCtorInClass](http://sevntu-checkstyle.github.io/sevntu.checkstyle/apidocs/com/github/sevntu/checkstyle/checks/coding/EmptyPublicCtorInClassCheck.html) + +This Check looks for useless empty public constructors. Class constructor is considered useless by this Check if and only if class has exactly one ctor, which is public, empty(one that has no statements) and default. + +Valid: +````java +class ValidPrivateCtor { + private ValidPrivateCtor() { + } +} + +class ValidOverloadedCtor { + public ValidOverloadedCtor() { + } + public ValidOverloadedCtor(int i) { + } +} +```` + +Invalid: +````java +class Invalid { + public Invalid() { + } +} +```` #### [EnumValueName](http://sevntu-checkstyle.github.io/sevntu.checkstyle/apidocs/com/github/sevntu/checkstyle/checks/naming/EnumValueNameCheck.html) Checks that Enum Values match the pattern: `^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$` @@ -2277,6 +2306,49 @@ enum InvalidConstants { alpha, Beta; } ```` +#### [FinalizeImplementation](http://sevntu-checkstyle.github.io/sevntu.checkstyle/apidocs/com/github/sevntu/checkstyle/checks/coding/FinalizeImplementationCheck.html) + +Checks that the `finalize()` implementation doesn't ignore the base class implementation, and doesn't *only* call the base class implementation. + +Valid: +```java +class Valid { + protected void finalize() { + try { + doSomething(); + } finally { + super.finalize(); + } + } +} +``` + +Invalid: +```java +class InvalidNoEffect1 { + protected void finalize() { + } +} +class InvalidNoEffect2 { + protected void finalize() { + doSomething(); + } +} +class InvalidUseless { + protected void finalize() { + super.finalize(); + } +} +class InvalidPublic { + public void finalize() { + try { + doSomething(); + } finally { + super.finalize(); + } + } +} +``` #### [ForbidCCommentsInMethods](http://sevntu-checkstyle.github.io/sevntu.checkstyle/apidocs/com/github/sevntu/checkstyle/checks/coding/ForbidCCommentsInMethodsCheck.html) Prevents the use of `/* C-style */` comments inside methods. @@ -2581,6 +2653,24 @@ class Derived extends Base { } } ```` +#### [WhitespaceBeforeArrayInitializer](http://sevntu-checkstyle.github.io/sevntu.checkstyle/apidocs/com/github/sevntu/checkstyle/checks/coding/WhitespaceBeforeArrayInitializerCheck.html) + +This checks enforces whitespace before array initializer. + +Valid: +````java +int[] ints = new int[] { + 0, 1, 2, 3 +}; + +int[] tab = new int[] + {0, 1, 2, 3}; +```` + +Invalid: +````java +int[] ints = new int[]{0, 1, 2, 3}; +```` ## Disabled Checks @@ -2671,9 +2761,6 @@ As the sevntu check are considered experimental not all those that are not enabl #### [AvoidConditionInversion](http://sevntu-checkstyle.github.io/sevntu.checkstyle/apidocs/com/github/sevntu/checkstyle/checks/design/AvoidConditionInversionCheck.html) Should already be covered by [SimplifyBooleanExpression](simplifybooleanexpression). -#### [AvoidDefaultSerializableInInnerClasses](http://sevntu-checkstyle.github.io/sevntu.checkstyle/apidocs/com/github/sevntu/checkstyle/checks/coding/AvoidDefaultSerializableInInnerClassesCheck.html) - -TODO: enable #### [AvoidModifiersForTypes](http://sevntu-checkstyle.github.io/sevntu.checkstyle/apidocs/com/github/sevntu/checkstyle/checks/coding/AvoidModifiersForTypesCheck.html) Generic rule; doesn't embody a 'quality' check. @@ -2686,12 +2773,6 @@ Appears to be broken as of `1.21.0`. #### [CustomDeclarationOrder](http://sevntu-checkstyle.github.io/sevntu.checkstyle/apidocs/com/github/sevntu/checkstyle/checks/coding/CustomDeclarationOrderCheck.html) The [DeclarationOrder](#declarationorder) check already imposes an order for class elements. -#### [EmptyPublicCtorInClass](http://sevntu-checkstyle.github.io/sevntu.checkstyle/apidocs/com/github/sevntu/checkstyle/checks/coding/EmptyPublicCtorInClassCheck.html) - -TODO: enable -#### [FinalizeImplementation](http://sevntu-checkstyle.github.io/sevntu.checkstyle/apidocs/com/github/sevntu/checkstyle/checks/coding/FinalizeImplementationCheck.html) - -TODO: enable #### [ForbidAnnotation](http://sevntu-checkstyle.github.io/sevntu.checkstyle/apidocs/com/github/sevntu/checkstyle/checks/annotation/ForbidAnnotationCheck.html) Generic rule; doesn't embody a 'quality' check. @@ -2710,8 +2791,5 @@ Generic rule; doesn't embody a 'quality' check. #### [StaticMethodCandidate](http://sevntu-checkstyle.github.io/sevntu.checkstyle/apidocs/com/github/sevntu/checkstyle/checks/design/StaticMethodCandidateCheck.html) Can't handle private methods called by reflection, which may cause issues with Spring and other DI frameworks. -#### [WhitespaceBeforeArrayInitializer](http://sevntu-checkstyle.github.io/sevntu.checkstyle/apidocs/com/github/sevntu/checkstyle/checks/coding/WhitespaceBeforeArrayInitializerCheck.html) - -TODO: enable [Effective Java]: http://amzn.to/2aSz6GE \ No newline at end of file diff --git a/builder/pom.xml b/builder/pom.xml index af2b242..1581267 100644 --- a/builder/pom.xml +++ b/builder/pom.xml @@ -7,11 +7,10 @@ net.kemitix kemitix-checkstyle-ruleset-parent - 3.2.0 + 3.3.0 kemitix-checkstyle-ruleset-builder - 3.2.0 jar Kemitix Checkstyle :: Ruleset :: Builder @@ -32,26 +31,6 @@ 2016 - - Brussels-SR2 - 1.5.3.RELEASE - 2.3.5 - 1.0.0 - 4.3.0 - - - - - - io.spring.platform - platform-bom - ${spring-platform.version} - pom - import - - - - org.springframework.boot @@ -75,39 +54,28 @@ com.speedment.common mapstream - ${mapstream.version} org.springframework.boot spring-boot-starter-test test - - org.assertj - assertj-core - ${assertj.version} - test - me.andrz map-builder - ${map-builder.version} test com.puppycrawl.tools checkstyle - ${checkstyle.version} - compile com.github.sevntu-checkstyle sevntu-checks - ${sevntu.version} - + diff --git a/builder/src/main/resources/application.yml b/builder/src/main/resources/application.yml index e3ef8a4..b6f3195 100644 --- a/builder/src/main/resources/application.yml +++ b/builder/src/main/resources/application.yml @@ -1392,11 +1392,10 @@ rules: - name: AvoidDefaultSerializableInInnerClasses parent: TREEWALKER - level: COMPLEXITY - enabled: false + level: TWEAKS + enabled: true source: SEVNTU uri: http://sevntu-checkstyle.github.io/sevntu.checkstyle/apidocs/com/github/sevntu/checkstyle/checks/coding/AvoidDefaultSerializableInInnerClassesCheck.html - reason: "TODO: enable" - name: AvoidModifiersForTypes parent: TREEWALKER @@ -1433,18 +1432,16 @@ rules: name: EmptyPublicCtorInClass parent: TREEWALKER level: TWEAKS - enabled: false + enabled: true source: SEVNTU uri: http://sevntu-checkstyle.github.io/sevntu.checkstyle/apidocs/com/github/sevntu/checkstyle/checks/coding/EmptyPublicCtorInClassCheck.html - reason: "TODO: enable" - name: FinalizeImplementation parent: TREEWALKER - level: - enabled: false + level: TWEAKS + enabled: true source: SEVNTU uri: http://sevntu-checkstyle.github.io/sevntu.checkstyle/apidocs/com/github/sevntu/checkstyle/checks/coding/FinalizeImplementationCheck.html - reason: "TODO: enable" - name: ForbidAnnotation parent: TREEWALKER @@ -1497,10 +1494,9 @@ rules: name: WhitespaceBeforeArrayInitializer parent: TREEWALKER level: LAYOUT - enabled: false + enabled: true source: SEVNTU uri: http://sevntu-checkstyle.github.io/sevntu.checkstyle/apidocs/com/github/sevntu/checkstyle/checks/coding/WhitespaceBeforeArrayInitializerCheck.html - reason: "TODO: enable" - name: MoveVariableInsideIfCheck parent: TREEWALKER diff --git a/builder/src/main/resources/rules/AvoidDefaultSerializableInInnerClasses.md b/builder/src/main/resources/rules/AvoidDefaultSerializableInInnerClasses.md new file mode 100644 index 0000000..db09462 --- /dev/null +++ b/builder/src/main/resources/rules/AvoidDefaultSerializableInInnerClasses.md @@ -0,0 +1,2 @@ + +Prevent the use of default serialization methods on inner classes. If an inner class needs to implement the Serializable interface, then it *must* implement both `writeObject()` and `readObject()` methods. diff --git a/builder/src/main/resources/rules/EmptyPublicCtorInClass.md b/builder/src/main/resources/rules/EmptyPublicCtorInClass.md new file mode 100644 index 0000000..52c7674 --- /dev/null +++ b/builder/src/main/resources/rules/EmptyPublicCtorInClass.md @@ -0,0 +1,25 @@ + +This Check looks for useless empty public constructors. Class constructor is considered useless by this Check if and only if class has exactly one ctor, which is public, empty(one that has no statements) and default. + +Valid: +````java +class ValidPrivateCtor { + private ValidPrivateCtor() { + } +} + +class ValidOverloadedCtor { + public ValidOverloadedCtor() { + } + public ValidOverloadedCtor(int i) { + } +} +```` + +Invalid: +````java +class Invalid { + public Invalid() { + } +} +```` diff --git a/builder/src/main/resources/rules/FinalizeImplementation.md b/builder/src/main/resources/rules/FinalizeImplementation.md new file mode 100644 index 0000000..323e07e --- /dev/null +++ b/builder/src/main/resources/rules/FinalizeImplementation.md @@ -0,0 +1,42 @@ + +Checks that the `finalize()` implementation doesn't ignore the base class implementation, and doesn't *only* call the base class implementation. + +Valid: +```java +class Valid { + protected void finalize() { + try { + doSomething(); + } finally { + super.finalize(); + } + } +} +``` + +Invalid: +```java +class InvalidNoEffect1 { + protected void finalize() { + } +} +class InvalidNoEffect2 { + protected void finalize() { + doSomething(); + } +} +class InvalidUseless { + protected void finalize() { + super.finalize(); + } +} +class InvalidPublic { + public void finalize() { + try { + doSomething(); + } finally { + super.finalize(); + } + } +} +``` diff --git a/builder/src/main/resources/rules/WhitespaceBeforeArrayInitializer.md b/builder/src/main/resources/rules/WhitespaceBeforeArrayInitializer.md new file mode 100644 index 0000000..75703f6 --- /dev/null +++ b/builder/src/main/resources/rules/WhitespaceBeforeArrayInitializer.md @@ -0,0 +1,17 @@ + +This checks enforces whitespace before array initializer. + +Valid: +````java +int[] ints = new int[] { + 0, 1, 2, 3 +}; + +int[] tab = new int[] + {0, 1, 2, 3}; +```` + +Invalid: +````java +int[] ints = new int[]{0, 1, 2, 3}; +```` diff --git a/builder/src/test/java/net/kemitix/checkstyle/ruleset/builder/CheckstyleWriterTest.java b/builder/src/test/java/net/kemitix/checkstyle/ruleset/builder/CheckstyleWriterTest.java index 5cd29f1..9f057ff 100644 --- a/builder/src/test/java/net/kemitix/checkstyle/ruleset/builder/CheckstyleWriterTest.java +++ b/builder/src/test/java/net/kemitix/checkstyle/ruleset/builder/CheckstyleWriterTest.java @@ -22,8 +22,8 @@ import java.util.Map; import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.Assertions.assertThatThrownBy; +import static org.mockito.ArgumentMatchers.any; import static org.mockito.BDDMockito.given; -import static org.mockito.Matchers.any; /** * Tests for {@link CheckstyleWriter}. diff --git a/plugin/pom.xml b/plugin/pom.xml index f16240c..a89b75d 100644 --- a/plugin/pom.xml +++ b/plugin/pom.xml @@ -7,7 +7,7 @@ net.kemitix kemitix-checkstyle-ruleset-parent - 3.2.0 + 3.3.0 kemitix-checkstyle-ruleset-maven-plugin diff --git a/plugin/src/test/java/net/kemitix/checkstyle/ruleset/plugin/CheckMojoTest.java b/plugin/src/test/java/net/kemitix/checkstyle/ruleset/plugin/CheckMojoTest.java index 0008532..86e540f 100644 --- a/plugin/src/test/java/net/kemitix/checkstyle/ruleset/plugin/CheckMojoTest.java +++ b/plugin/src/test/java/net/kemitix/checkstyle/ruleset/plugin/CheckMojoTest.java @@ -16,9 +16,9 @@ import org.mockito.Mock; import org.mockito.MockitoAnnotations; import static org.assertj.core.api.Assertions.assertThat; +import static org.mockito.ArgumentMatchers.any; import static org.mockito.BDDMockito.given; import static org.mockito.BDDMockito.then; -import static org.mockito.Matchers.any; /** * Tests for {@link CheckMojo}. diff --git a/plugin/src/test/java/net/kemitix/checkstyle/ruleset/plugin/DefaultCheckstyleExecutorTest.java b/plugin/src/test/java/net/kemitix/checkstyle/ruleset/plugin/DefaultCheckstyleExecutorTest.java index 8abc7b1..b7de3cb 100644 --- a/plugin/src/test/java/net/kemitix/checkstyle/ruleset/plugin/DefaultCheckstyleExecutorTest.java +++ b/plugin/src/test/java/net/kemitix/checkstyle/ruleset/plugin/DefaultCheckstyleExecutorTest.java @@ -29,10 +29,10 @@ import java.util.ArrayList; import java.util.List; import java.util.Properties; +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.ArgumentMatchers.eq; import static org.mockito.BDDMockito.given; import static org.mockito.BDDMockito.then; -import static org.mockito.Matchers.any; -import static org.mockito.Matchers.eq; /** * Tests for {@link DefaultCheckstyleExecutor}. diff --git a/plugin/src/test/java/net/kemitix/checkstyle/ruleset/plugin/DefaultPluginExecutorTest.java b/plugin/src/test/java/net/kemitix/checkstyle/ruleset/plugin/DefaultPluginExecutorTest.java index 9ce752c..ba5f6b2 100644 --- a/plugin/src/test/java/net/kemitix/checkstyle/ruleset/plugin/DefaultPluginExecutorTest.java +++ b/plugin/src/test/java/net/kemitix/checkstyle/ruleset/plugin/DefaultPluginExecutorTest.java @@ -26,10 +26,10 @@ import org.twdata.maven.mojoexecutor.MojoExecutor; import java.util.List; import static org.assertj.core.api.Assertions.assertThat; +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.ArgumentMatchers.eq; import static org.mockito.BDDMockito.given; import static org.mockito.BDDMockito.then; -import static org.mockito.Matchers.any; -import static org.mockito.Matchers.eq; /** * Tests for {@link DefaultPluginExecutor}. diff --git a/pom.xml b/pom.xml index 12ea188..2cadc77 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ kemitix-checkstyle-ruleset-parent - 3.2.0 + 3.3.0 pom Kemitix Checkstyle :: Ruleset :: Parent @@ -19,10 +19,17 @@ 2.17 - 7.8 - 1.24.0 + 8.0 + 1.24.1 - 1.10.19 + Brussels-SR3 + 1.5.4.RELEASE + 2.3.5 + 1.0.0 + 4.3.0 + 2.5.6 + + 2.8.47 3.8.0 @@ -50,6 +57,28 @@ + + com.puppycrawl.tools + checkstyle + ${checkstyle.version} + + + com.github.sevntu-checkstyle + sevntu-checks + ${sevntu.version} + + + io.spring.platform + platform-bom + ${spring-platform.version} + pom + import + + + com.speedment.common + mapstream + ${mapstream.version} + org.mockito mockito-core @@ -60,6 +89,16 @@ assertj-core ${assertj.version} + + me.andrz + map-builder + ${map-builder.version} + + + org.immutables + value + ${immutables-value.version} + diff --git a/regressions/pom.xml b/regressions/pom.xml index 0bc97be..5ee54fa 100644 --- a/regressions/pom.xml +++ b/regressions/pom.xml @@ -6,7 +6,7 @@ net.kemitix kemitix-checkstyle-ruleset-parent - 3.2.0 + 3.3.0 kemitix-checkstyle-ruleset-regressions @@ -16,14 +16,12 @@ ${project.version} 5-complexity true - 2.4.4 org.immutables value - ${immutables.version} provided diff --git a/regressions/src/main/java/net/kemitix/checkstyle/regressions/AvoidDefaultSerializableInInnerClasses.java b/regressions/src/main/java/net/kemitix/checkstyle/regressions/AvoidDefaultSerializableInInnerClasses.java new file mode 100644 index 0000000..1ac2c72 --- /dev/null +++ b/regressions/src/main/java/net/kemitix/checkstyle/regressions/AvoidDefaultSerializableInInnerClasses.java @@ -0,0 +1,41 @@ +/** + * The MIT License (MIT) + * + * Copyright (c) 2017 Paul Campbell + * + * Permission is hereby granted, free of charge, to any person obtaining a copy of this software + * and associated documentation files (the "Software"), to deal in the Software without restriction, + * including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, + * and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, + * subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in all copies + * or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, + * INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE + * AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, + * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. + */ + +package net.kemitix.checkstyle.regressions; + +import java.io.Serializable; + +/** + * Regression test for {@code AvoidDefaultSerializableInInnerClasses}. + * + * @author Paul Campbell (pcampbell@kemitix.net) + */ +public class AvoidDefaultSerializableInInnerClasses { + + /** + * Inner class should not use default implementations of {@code readObject()} and {@code writeObject()}. + */ + @SuppressWarnings("avoiddefaultserializableininnerclasses") + public class InnerClass implements Serializable { + + } + +} diff --git a/regressions/src/main/java/net/kemitix/checkstyle/regressions/EmptyPublicCtorInClass.java b/regressions/src/main/java/net/kemitix/checkstyle/regressions/EmptyPublicCtorInClass.java new file mode 100644 index 0000000..1ce63b0 --- /dev/null +++ b/regressions/src/main/java/net/kemitix/checkstyle/regressions/EmptyPublicCtorInClass.java @@ -0,0 +1,38 @@ +/** + * The MIT License (MIT) + * + * Copyright (c) 2017 Paul Campbell + * + * Permission is hereby granted, free of charge, to any person obtaining a copy of this software + * and associated documentation files (the "Software"), to deal in the Software without restriction, + * including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, + * and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, + * subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in all copies + * or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, + * INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE + * AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, + * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. + */ + +package net.kemitix.checkstyle.regressions; + +/** + * Regression demo for {@code EmptyPublicCtorInClassCheck}. + * + * @author Paul Campbell (pcampbell@kemitix.net) + */ +public class EmptyPublicCtorInClass { + + /** + * Useless empty public constructors. + */ + @SuppressWarnings("emptypublicctorinclass") + EmptyPublicCtorInClass() { + } + +} diff --git a/regressions/src/main/java/net/kemitix/checkstyle/regressions/ExplicitInitialization.java b/regressions/src/main/java/net/kemitix/checkstyle/regressions/ExplicitInitialization.java index d2987c1..8742195 100644 --- a/regressions/src/main/java/net/kemitix/checkstyle/regressions/ExplicitInitialization.java +++ b/regressions/src/main/java/net/kemitix/checkstyle/regressions/ExplicitInitialization.java @@ -26,7 +26,7 @@ package net.kemitix.checkstyle.regressions; * * @author Paul Campbell (pcampbell@kemitix.net). */ -@SuppressWarnings("hideutilityclassconstructor") +@SuppressWarnings({"hideutilityclassconstructor", "PMD.UnusedPrivateField"}) class ExplicitInitialization { private boolean validBoolean = false; diff --git a/regressions/src/main/java/net/kemitix/checkstyle/regressions/FinalizeImplementation.java b/regressions/src/main/java/net/kemitix/checkstyle/regressions/FinalizeImplementation.java new file mode 100644 index 0000000..738f7de --- /dev/null +++ b/regressions/src/main/java/net/kemitix/checkstyle/regressions/FinalizeImplementation.java @@ -0,0 +1,39 @@ +/** + * The MIT License (MIT) + * + * Copyright (c) 2017 Paul Campbell + * + * Permission is hereby granted, free of charge, to any person obtaining a copy of this software + * and associated documentation files (the "Software"), to deal in the Software without restriction, + * including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, + * and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, + * subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in all copies + * or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, + * INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE + * AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, + * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. + */ + +package net.kemitix.checkstyle.regressions; + +/** + * Regression test for {@code FinalizeImplementationCheck}. + * + * @author Paul Campbell pcampbell@kemitix.net + */ +class FinalizeImplementation { + + /** + * Negates effect of superclass finalize. + */ + @SuppressWarnings({"PMD.EmptyFinalizer", "nofinalizer", "finalizeimplementation"}) + protected void finalize() { + // doesn't call super.finalize() + } + +} diff --git a/ruleset/pom.xml b/ruleset/pom.xml index b45a60f..573adc8 100644 --- a/ruleset/pom.xml +++ b/ruleset/pom.xml @@ -7,11 +7,10 @@ net.kemitix kemitix-checkstyle-ruleset-parent - 3.2.0 + 3.3.0 kemitix-checkstyle-ruleset - 3.2.0 jar Kemitix Checkstyle :: Ruleset diff --git a/ruleset/src/main/resources/net/kemitix/checkstyle-1-layout.xml b/ruleset/src/main/resources/net/kemitix/checkstyle-1-layout.xml index dcb2199..8b69e34 100644 --- a/ruleset/src/main/resources/net/kemitix/checkstyle-1-layout.xml +++ b/ruleset/src/main/resources/net/kemitix/checkstyle-1-layout.xml @@ -59,6 +59,7 @@ + diff --git a/ruleset/src/main/resources/net/kemitix/checkstyle-2-naming.xml b/ruleset/src/main/resources/net/kemitix/checkstyle-2-naming.xml index a4a70a0..330545e 100644 --- a/ruleset/src/main/resources/net/kemitix/checkstyle-2-naming.xml +++ b/ruleset/src/main/resources/net/kemitix/checkstyle-2-naming.xml @@ -91,6 +91,7 @@ + diff --git a/ruleset/src/main/resources/net/kemitix/checkstyle-3-javadoc.xml b/ruleset/src/main/resources/net/kemitix/checkstyle-3-javadoc.xml index 5536268..00f2043 100644 --- a/ruleset/src/main/resources/net/kemitix/checkstyle-3-javadoc.xml +++ b/ruleset/src/main/resources/net/kemitix/checkstyle-3-javadoc.xml @@ -117,6 +117,7 @@ + diff --git a/ruleset/src/main/resources/net/kemitix/checkstyle-4-tweaks.xml b/ruleset/src/main/resources/net/kemitix/checkstyle-4-tweaks.xml index 08ac646..0358887 100644 --- a/ruleset/src/main/resources/net/kemitix/checkstyle-4-tweaks.xml +++ b/ruleset/src/main/resources/net/kemitix/checkstyle-4-tweaks.xml @@ -177,6 +177,10 @@ + + + + diff --git a/ruleset/src/main/resources/net/kemitix/checkstyle-5-complexity.xml b/ruleset/src/main/resources/net/kemitix/checkstyle-5-complexity.xml index 95ead8f..e3a5f44 100644 --- a/ruleset/src/main/resources/net/kemitix/checkstyle-5-complexity.xml +++ b/ruleset/src/main/resources/net/kemitix/checkstyle-5-complexity.xml @@ -230,6 +230,10 @@ + + + +