From 710cfd151bad6e07bed10c81e9bf373e4214da08 Mon Sep 17 00:00:00 2001 From: Paul Campbell Date: Mon, 29 May 2017 13:34:52 +0100 Subject: [PATCH 1/3] KCR37: regressions: MoveVariableInsideIf: invalid(): use explicit scope --- .../kemitix/checkstyle/regressions/MoveVariableInsideIf.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/regressions/src/main/java/net/kemitix/checkstyle/regressions/MoveVariableInsideIf.java b/regressions/src/main/java/net/kemitix/checkstyle/regressions/MoveVariableInsideIf.java index bfdb49d..33dc9bd 100644 --- a/regressions/src/main/java/net/kemitix/checkstyle/regressions/MoveVariableInsideIf.java +++ b/regressions/src/main/java/net/kemitix/checkstyle/regressions/MoveVariableInsideIf.java @@ -42,7 +42,7 @@ class MoveVariableInsideIf { * @return value */ @SuppressWarnings("movevariableinsideif") - String invalid() { + private String invalid() { String variable = input.substring(1); if (condition) { return method(variable); From b6521b809c937fa6b68ca9245c1d6276fcb5b709 Mon Sep 17 00:00:00 2001 From: Paul Campbell Date: Mon, 29 May 2017 13:35:19 +0100 Subject: [PATCH 2/3] KCR38: regressions: MoveVariableInsideIf: valid(): use explicit scope --- .../kemitix/checkstyle/regressions/MoveVariableInsideIf.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/regressions/src/main/java/net/kemitix/checkstyle/regressions/MoveVariableInsideIf.java b/regressions/src/main/java/net/kemitix/checkstyle/regressions/MoveVariableInsideIf.java index 33dc9bd..bea9d91 100644 --- a/regressions/src/main/java/net/kemitix/checkstyle/regressions/MoveVariableInsideIf.java +++ b/regressions/src/main/java/net/kemitix/checkstyle/regressions/MoveVariableInsideIf.java @@ -55,7 +55,7 @@ class MoveVariableInsideIf { * * @return value */ - String valid() { + private String valid() { if (condition) { String variable = input.substring(1); return method(variable); From 1a5ca4ceef1df94a255e8ef7751e23e619fe0010 Mon Sep 17 00:00:00 2001 From: Paul Campbell Date: Mon, 29 May 2017 14:10:04 +0100 Subject: [PATCH 3/3] KCR37+38: MoveVariableInsideIf: avoid unused private methods --- .../kemitix/checkstyle/regressions/MoveVariableInsideIf.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/regressions/src/main/java/net/kemitix/checkstyle/regressions/MoveVariableInsideIf.java b/regressions/src/main/java/net/kemitix/checkstyle/regressions/MoveVariableInsideIf.java index bea9d91..a13ccb3 100644 --- a/regressions/src/main/java/net/kemitix/checkstyle/regressions/MoveVariableInsideIf.java +++ b/regressions/src/main/java/net/kemitix/checkstyle/regressions/MoveVariableInsideIf.java @@ -42,7 +42,7 @@ class MoveVariableInsideIf { * @return value */ @SuppressWarnings("movevariableinsideif") - private String invalid() { + protected String invalid() { String variable = input.substring(1); if (condition) { return method(variable); @@ -55,7 +55,7 @@ class MoveVariableInsideIf { * * @return value */ - private String valid() { + protected String valid() { if (condition) { String variable = input.substring(1); return method(variable);