From e10b3c00326fe4f32c215386e8ba4c0b64eb1542 Mon Sep 17 00:00:00 2001 From: Paul Campbell Date: Fri, 9 Sep 2016 19:09:48 +0100 Subject: [PATCH] NoFinalizer: enabled --- README.md | 12 +++++++----- src/main/resources/net/kemitix/checkstyle.xml | 1 + 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index b32456a..8097ef0 100644 --- a/README.md +++ b/README.md @@ -207,7 +207,7 @@ You need to include `checkstyle` as the version bundled with the `maven-checksty * [NestedTryDepth](#nestedtrydepth) - checkstyle - enabled * [NewlineAtEndOfFile](#newlineatendoffile) - checkstyle - enabled * [NoClone](#noclone) - checkstyle - enabled -* [NoFinalizer](#nofinalizer) - checkstyle - disabled +* [NoFinalizer](#nofinalizer) - checkstyle - enabled * [NoLineWrap](#nolinewrap) - checkstyle - disabled * [NoMainMethodInAbstractClass](#nomainmethodinabstractclass) - sevntu - enabled * [NonEmptyAtclauseDescription](#nonemptyatclausedescription) - checkstyle - enabled @@ -1658,6 +1658,12 @@ Checks that the `clone()` method from `Object` has not been overridden. Use a c > See [Effective Java], 2nd Edition by Josh Bloch: Item 11: Override clone judiciously. +#### [NoFinalizer](http://checkstyle.sourceforge.net/config_coding.html#NoFinalizer) + +Checks that the `finalize()` method from `Object` has not been overridden. + +> See [Effective Java], 2nd Edition by Josh Bloch: Item 7: Avoid finalizers. + #### [NonEmptyAtclauseDescription](http://checkstyle.sourceforge.net/config_javadoc.html#NonEmptyAtclauseDescription) Checks that the Javadoc clauses `@param`, `@return`, `@throws` and `@deprecated` all have descriptions. @@ -2714,10 +2720,6 @@ Would not see constructors created using Lombok's `@NoArgsConstructor`. The javadoc compiler automatically inherits the javadoc from the overridden method, it doesn't need to be told to do so. -#### [NoFinalizer](http://checkstyle.sourceforge.net/config_coding.html#NoFinalizer) - -> TODO: enable - #### [NoLineWrap](http://checkstyle.sourceforge.net/config_whitespace.html#NoLineWrap) > TODO: enable diff --git a/src/main/resources/net/kemitix/checkstyle.xml b/src/main/resources/net/kemitix/checkstyle.xml index 3845af1..676002c 100644 --- a/src/main/resources/net/kemitix/checkstyle.xml +++ b/src/main/resources/net/kemitix/checkstyle.xml @@ -159,6 +159,7 @@ +