builder:DefaultRuleReadmeLoaderTest: added

builder/src/main/java/net/kemitix/checkstyle/ruleset/builder/DefaultRuleReadmeLoader.java

@@ -51,13 +51,11 @@ class DefaultRuleReadmeLoader implements RuleReadmeLoader {
             final Path resolve = templateProperties.getReadmeFragments()
                                                    .resolve(rule.getName() + ".md");
             log.info("Loading fragment: {}", resolve);
-            Stream<String> result = Stream.empty();
             try {
-                result = Stream.concat(Stream.of(formatRuleHeader(rule)), Files.lines(resolve));
+                return Stream.concat(Stream.of(formatRuleHeader(rule)), Files.lines(resolve));
             } catch (IOException e) {
-                log.error("Failed to load fragment: {}", resolve);
+                throw new ReadmeFragmentNotFoundException(rule.getName(), e);
             }
-            return result;
         } else {
             return Stream.of(formatRuleHeader(rule), "", rule.getReason());
         }

builder/src/test/java/net/kemitix/checkstyle/ruleset/builder/DefaultRuleReadmeLoaderTest.java

@@ -0,0 +1,84 @@
+package net.kemitix.checkstyle.ruleset.builder;
+
+import lombok.val;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.rules.ExpectedException;
+import org.junit.rules.TemporaryFolder;
+
+import java.io.IOException;
+import java.net.URI;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.Arrays;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+/**
+ * Tests for {@link DefaultRuleReadmeLoader}.
+ *
+ * @author Paul Campbell (pcampbell@kemitix.net)
+ */
+public class DefaultRuleReadmeLoaderTest {
+
+    private RuleReadmeLoader loader;
+
+    private TemplateProperties templateProperties;
+
+    private Rule rule;
+
+    private Path fragment;
+
+    private Path fragments;
+
+    @org.junit.Rule
+    public TemporaryFolder folder = new TemporaryFolder();
+
+    @org.junit.Rule
+    public ExpectedException exception = ExpectedException.none();
+
+    @Before
+    public void setUp() throws Exception {
+        templateProperties = new TemplateProperties();
+        fragments = folder.newFolder("fragments")
+                          .toPath();
+        templateProperties.setReadmeFragments(fragments);
+        loader = new DefaultRuleReadmeLoader(templateProperties);
+        rule = new Rule();
+        rule.setName("name");
+        rule.setUri(URI.create("uri"));
+    }
+
+    @Test
+    public void loadEnabledOkay() throws IOException {
+        //given
+        rule.setEnabled(true);
+        fragment = fragments.resolve("name.md");
+        Files.write(fragment, Arrays.asList("", "body"));
+        //when
+        val fragment = loader.load(rule);
+        //then
+        assertThat(fragment).containsExactlyElementsOf(Arrays.asList("#### [name](uri)", "", "body"));
+    }
+
+    @Test
+    public void loadEnabledWithMissingFragment() {
+        //given
+        rule.setEnabled(true);
+        exception.expect(ReadmeFragmentNotFoundException.class);
+        exception.expectMessage("name");
+        //when
+        loader.load(rule);
+    }
+
+    @Test
+    public void loadDisabled() {
+        //given
+        rule.setEnabled(false);
+        rule.setReason("reason");
+        //when
+        val fragment = loader.load(rule);
+        //then
+        assertThat(fragment).containsExactlyElementsOf(Arrays.asList("#### [name](uri)", "", "reason"));
+    }
+}