From ee7eb75ffb01c6c77c9715d623c31eefe7a81fec Mon Sep 17 00:00:00 2001 From: Paul Campbell Date: Sun, 26 Aug 2018 15:49:02 +0100 Subject: [PATCH] ruleset: fix order of properties and adjust indentation --- .../checkstyle/ruleset/builder/Rule.java | 6 +- .../net/kemitix/checkstyle-1-layout.xml | 20 ++--- .../net/kemitix/checkstyle-2-naming.xml | 24 +++--- .../net/kemitix/checkstyle-3-javadoc.xml | 36 ++++----- .../net/kemitix/checkstyle-4-tweaks.xml | 52 ++++++------- .../net/kemitix/checkstyle-5-complexity.xml | 74 +++++++++---------- 6 files changed, 107 insertions(+), 105 deletions(-) diff --git a/builder/src/main/java/net/kemitix/checkstyle/ruleset/builder/Rule.java b/builder/src/main/java/net/kemitix/checkstyle/ruleset/builder/Rule.java index 30848f7..73323a8 100644 --- a/builder/src/main/java/net/kemitix/checkstyle/ruleset/builder/Rule.java +++ b/builder/src/main/java/net/kemitix/checkstyle/ruleset/builder/Rule.java @@ -27,6 +27,7 @@ import lombok.Setter; import net.kemitix.conditional.Value; import java.net.URI; +import java.util.Comparator; import java.util.HashMap; import java.util.Locale; import java.util.Map; @@ -46,7 +47,7 @@ public class Rule { private static final String MODULE_NO_PROPERTIES = ""; - private static final String MODULE_WITH_PROPERTIES = "%n %s%n"; + private static final String MODULE_WITH_PROPERTIES = "%n%s%n"; /** * Configuration properties. @@ -133,7 +134,8 @@ public class Rule { private static String formatProperties(final Map properties) { return MapStream.of(properties) - .map((k, v) -> String.format("", k, v)) + .sorted(Comparator.comparing(Map.Entry::getKey)) + .map((k, v) -> String.format(" ", k, v)) .collect(Collectors.joining(System.lineSeparator())); } diff --git a/ruleset/src/main/resources/net/kemitix/checkstyle-1-layout.xml b/ruleset/src/main/resources/net/kemitix/checkstyle-1-layout.xml index 5378d67..8dffd66 100644 --- a/ruleset/src/main/resources/net/kemitix/checkstyle-1-layout.xml +++ b/ruleset/src/main/resources/net/kemitix/checkstyle-1-layout.xml @@ -5,16 +5,16 @@ - - + + - - + + - + @@ -30,13 +30,13 @@ - + - - + + @@ -45,8 +45,8 @@ - - + + diff --git a/ruleset/src/main/resources/net/kemitix/checkstyle-2-naming.xml b/ruleset/src/main/resources/net/kemitix/checkstyle-2-naming.xml index 4125034..6140730 100644 --- a/ruleset/src/main/resources/net/kemitix/checkstyle-2-naming.xml +++ b/ruleset/src/main/resources/net/kemitix/checkstyle-2-naming.xml @@ -5,16 +5,16 @@ - - + + - - + + - + @@ -37,7 +37,7 @@ - + @@ -52,27 +52,27 @@ - - + + - + - - + + - + diff --git a/ruleset/src/main/resources/net/kemitix/checkstyle-3-javadoc.xml b/ruleset/src/main/resources/net/kemitix/checkstyle-3-javadoc.xml index 2463ad3..073357f 100644 --- a/ruleset/src/main/resources/net/kemitix/checkstyle-3-javadoc.xml +++ b/ruleset/src/main/resources/net/kemitix/checkstyle-3-javadoc.xml @@ -5,17 +5,17 @@ - - + + - - + + - + @@ -29,7 +29,7 @@ - + @@ -43,16 +43,16 @@ - - - + + + - + @@ -69,8 +69,8 @@ - - + + @@ -78,29 +78,29 @@ - + - - + + - + - + - + diff --git a/ruleset/src/main/resources/net/kemitix/checkstyle-4-tweaks.xml b/ruleset/src/main/resources/net/kemitix/checkstyle-4-tweaks.xml index c30f4f8..4507b73 100644 --- a/ruleset/src/main/resources/net/kemitix/checkstyle-4-tweaks.xml +++ b/ruleset/src/main/resources/net/kemitix/checkstyle-4-tweaks.xml @@ -5,17 +5,17 @@ - - + + - - + + - + @@ -29,10 +29,10 @@ - + - + @@ -42,21 +42,21 @@ - + - + - - + + @@ -64,22 +64,22 @@ - + - - - + + + - + @@ -91,7 +91,7 @@ - + @@ -103,8 +103,8 @@ - - + + @@ -115,34 +115,34 @@ - + - + - - + + - + - + - + diff --git a/ruleset/src/main/resources/net/kemitix/checkstyle-5-complexity.xml b/ruleset/src/main/resources/net/kemitix/checkstyle-5-complexity.xml index 374a07f..aff64d6 100644 --- a/ruleset/src/main/resources/net/kemitix/checkstyle-5-complexity.xml +++ b/ruleset/src/main/resources/net/kemitix/checkstyle-5-complexity.xml @@ -5,20 +5,20 @@ - - + + - + - - + + - + @@ -33,15 +33,15 @@ - + - + - + @@ -51,14 +51,14 @@ - + - + @@ -67,15 +67,15 @@ - + - - + + @@ -83,38 +83,38 @@ - + - - - + + + - - - + + + - + - + - + @@ -122,7 +122,7 @@ - + @@ -132,19 +132,19 @@ - + - - + + - + @@ -154,22 +154,22 @@ - + - + - + - - + + @@ -177,18 +177,18 @@ - + - + - +