jenkins: update to follow latest template

Jenkinsfile.groovy

@@ -1,33 +1,25 @@
+final String publicRepo = 'https://github.com/kemitix/'
 final String mvn = "mvn --batch-mode --update-snapshots --errors"
 final dependenciesSupportJDK=9
 
 pipeline {
     agent any
     stages {
-        stage('master != SNAPSHOT') {
-            // checks that the pom version is not a snapshot when the current or target branch is master
-            when {
-                expression {
-                    (env.GIT_BRANCH == 'master' || env.CHANGE_TARGET == 'master') &&
-                            (readMavenPom(file: 'pom.xml').version).contains("SNAPSHOT")
-                }
-            }
-            steps {
-                error("Build failed because SNAPSHOT version")
-            }
-        }
         stage('Build & Test') {
             steps {
-                withMaven(maven: 'maven', jdk: 'JDK LTS') {
+                withMaven(maven: 'maven', jdk: 'JDK 1.8') {
                     sh "${mvn} clean compile checkstyle:checkstyle pmd:pmd test"
-                    //junit '**/target/surefire-reports/*.xml'
+                    // Code Coverage to Codacy
                     sh "${mvn} -pl builder jacoco:report com.gavinmogan:codacy-maven-plugin:coverage " +
                             "-DcoverageReportFile=target/site/jacoco/jacoco.xml " +
                             "-DprojectToken=`$JENKINS_HOME/codacy/token` " +
                             "-DapiToken=`$JENKINS_HOME/codacy/apitoken` " +
                             "-Dcommit=`git rev-parse HEAD`"
+                    // Code Coverage to Jenkins
                     jacoco exclusionPattern: '**/*{Test|IT|Main|Application|Immutable}.class'
+                    // PMD to Jenkins
                     pmd canComputeNew: false, defaultEncoding: '', healthy: '', pattern: '', unHealthy: ''
+                    // Checkstyle to Jenkins
                     step([$class: 'hudson.plugins.checkstyle.CheckStylePublisher',
                           pattern: '**/target/checkstyle-result.xml',
                           healthy:'20',
@@ -37,32 +29,32 @@ pipeline {
         }
         stage('Verify & Install') {
             steps {
-                withMaven(maven: 'maven', jdk: 'JDK LTS') {
+                withMaven(maven: 'maven', jdk: 'JDK 1.8') {
                     sh "${mvn} -DskipTests install"
                 }
             }
         }
-        stage('SonarQube (github only)') {
+        stage('SonarQube (published)') {
-            when { expression { env.GIT_URL.startsWith('https://github.com') } }
+            when { expression { isPublished(publicRepo) } }
             steps {
                 withSonarQubeEnv('sonarqube') {
-                    withMaven(maven: 'maven', jdk: 'JDK LTS') {
+                    withMaven(maven: 'maven', jdk: 'JDK 1.8') {
                         sh "${mvn} org.sonarsource.scanner.maven:sonar-maven-plugin:3.4.0.905:sonar"
                     }
                 }
             }
         }
-        stage('Archiving') {
+        stage('Deploy (published release branch)') {
-            when { expression { findFiles(glob: '**/target/*.jar').length > 0 } }
+            when {
-            steps {
+                expression {
-                archiveArtifacts '**/target/*.jar'
+                    (isReleaseBranch() &&
+                            isPublished(publicRepo) &&
+                            notSnapshot())
                 }
             }
-        stage('Deploy (master on github)') {
-            when { expression { (env.GIT_BRANCH == 'master' && env.GIT_URL.startsWith('https://github.com')) } }
             steps {
-                withMaven(maven: 'maven', jdk: 'JDK LTS') {
+                withMaven(maven: 'maven', jdk: 'JDK 1.8') {
-                    sh "${mvn} deploy -pl ruleset,tile --activate-profiles release -DskipTests=true"
+                    sh "${mvn} -pl ruleset,tile --activate-profiles release deploy"
                 }
             }
         }
@@ -84,3 +76,23 @@ pipeline {
         }
     }
 }
+
+private boolean isReleaseBranch() {
+    return branchStartsWith('release/')
+}
+
+private boolean branchStartsWith(final String branchName) {
+    startsWith(env.GIT_BRANCH, branchName)
+}
+
+private boolean isPublished(final String repo) {
+    startsWith(env.GIT_URL, repo)
+}
+
+private static boolean startsWith(final String value, final String match) {
+    value != null && value.startsWith(match)
+}
+
+private boolean notSnapshot() {
+    return !(readMavenPom(file: 'pom.xml').version).contains("SNAPSHOT")
+}