From c62d32a8b14b861f4296ade2b3b207770f3c4648 Mon Sep 17 00:00:00 2001
From: Paul Campbell <pcampbell@kemitix.net>
Date: Fri, 20 Mar 2020 09:05:21 +0000
Subject: [PATCH] Update rules (#18)

* Discontinue using Rule UnsynchronizedStaticDateFormatter

[WARNING] Discontinue using Rule name category/java/multithreading.xml/UnsynchronizedStaticDateFormatter as it is scheduled for removal from PMD. PMD 7.0.0 will remove support for this Rule.

* Fix constraints for DataflowAnomalyAnalysis

[WARNING] Removed misconfigured rule: DataflowAnomalyAnalysis cause: Constraint violated on property value '0' (Should be between 1 and 2000)

* Fix CommentRequired uses deprecated property

[WARNING] Rule CommentRequired uses deprecated property 'headerCommentRequirement'. Future versions of PMD will remove support for this property. Please use 'classCommentRequirement' instead!

* Replace deprecated rule with InvalidLogMessageFormat

[WARNING] Use Rule name category/java/errorprone.xml/InvalidLogMessageFormat instead of the deprecated Rule name category/java/errorprone.xml/InvalidSlf4jMessageFormat. PMD 7.0.0 will remove support for this deprecated Rule name usage.

* Remove deprecated rule LoggerIsNotStaticFinal

[WARNING] Discontinue using Rule name category/java/errorprone.xml/LoggerIsNotStaticFinal as it is scheduled for removal from PMD. PMD 7.0.0 will remove support for this Rule.
---
 src/main/resources/net/kemitix/pmd/java.xml | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/main/resources/net/kemitix/pmd/java.xml b/src/main/resources/net/kemitix/pmd/java.xml
index 65e0a31..37534e2 100644
--- a/src/main/resources/net/kemitix/pmd/java.xml
+++ b/src/main/resources/net/kemitix/pmd/java.xml
@@ -188,7 +188,7 @@ http://pmd.sourceforge.net/ruleset/2.0.0 ">
         <properties>
             <property name="enumCommentRequirement" value="Ignored"/>
             <property name="fieldCommentRequirement" value="Ignored"/>
-            <property name="headerCommentRequirement" value="Ignored"/>
+            <property name="classCommentRequirement" value="Ignored"/>
             <!-- only public and protected methods are required -->
         </properties>
     </rule>
@@ -232,7 +232,7 @@ http://pmd.sourceforge.net/ruleset/2.0.0 ">
     <rule ref="category/java/errorprone.xml/ConstructorCallsOverridableMethod"/>
     <rule ref="category/java/errorprone.xml/DataflowAnomalyAnalysis">
         <properties>
-            <property name="maxViolations" value="0"/>
+            <property name="maxViolations" value="1"/>
         </properties>
     </rule>
     <rule ref="category/java/errorprone.xml/DoNotCallGarbageCollectionExplicitly"/>
@@ -265,11 +265,10 @@ http://pmd.sourceforge.net/ruleset/2.0.0 ">
     <rule ref="category/java/errorprone.xml/IdempotentOperations" />
     <rule ref="category/java/errorprone.xml/ImportFromSamePackage" />
     <rule ref="category/java/errorprone.xml/InstantiationToGetClass" />
-    <rule ref="category/java/errorprone.xml/InvalidSlf4jMessageFormat" />
+    <rule ref="category/java/errorprone.xml/InvalidLogMessageFormat" />
     <rule ref="category/java/errorprone.xml/JumbledIncrementer" />
     <rule ref="category/java/errorprone.xml/JUnitSpelling" />
     <rule ref="category/java/errorprone.xml/JUnitStaticSuite" />
-    <rule ref="category/java/errorprone.xml/LoggerIsNotStaticFinal" />
     <rule ref="category/java/errorprone.xml/MethodWithSameNameAsEnclosingClass" />
     <rule ref="category/java/errorprone.xml/MisplacedNullCheck" />
     <rule ref="category/java/errorprone.xml/MissingBreakInSwitch" />
@@ -309,7 +308,6 @@ http://pmd.sourceforge.net/ruleset/2.0.0 ">
     <rule ref="category/java/multithreading.xml/DontCallThreadRun" />
     <rule ref="category/java/multithreading.xml/DoubleCheckedLocking" />
     <rule ref="category/java/multithreading.xml/NonThreadSafeSingleton" />
-    <rule ref="category/java/multithreading.xml/UnsynchronizedStaticDateFormatter" />
     <rule ref="category/java/multithreading.xml/UseConcurrentHashMap" />
     <rule ref="category/java/multithreading.xml/UseNotifyAllInsteadOfNotify" />