From e2a131e9082e0a40b5a080d37b838869c4910232 Mon Sep 17 00:00:00 2001
From: Paul Campbell <pcampbell@kemitix.net>
Date: Mon, 3 Sep 2018 08:56:50 +0100
Subject: [PATCH 1/3] The new Java rule FieldNamingConventions (java-codestyle)

Detects field names that don't comply to a given convention. It defaults to
standard Java convention of using camelCase, but can be configured with ease for
e.g. constants or static fields.
---
 src/main/resources/net/kemitix/pmd/java.xml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/main/resources/net/kemitix/pmd/java.xml b/src/main/resources/net/kemitix/pmd/java.xml
index b114b1f..c733932 100644
--- a/src/main/resources/net/kemitix/pmd/java.xml
+++ b/src/main/resources/net/kemitix/pmd/java.xml
@@ -98,6 +98,7 @@ http://pmd.sourceforge.net/ruleset/2.0.0 ">
             <property name="ignoreEnumDeclarations" value="false"/>
         </properties>
     </rule>
+    <rule ref="category/java/codestyle.xml/FieldNamingConventions" />
     <rule ref="category/java/codestyle.xml/ForLoopShouldBeWhileLoop"/>
     <rule ref="category/java/codestyle.xml/ForLoopsMustUseBraces"/>
     <rule ref="category/java/codestyle.xml/GenericsNaming"/>

From 0609e158f76a8950e788ef6bd48d65221d1ba34b Mon Sep 17 00:00:00 2001
From: Paul Campbell <pcampbell@kemitix.net>
Date: Mon, 3 Sep 2018 08:57:37 +0100
Subject: [PATCH 2/3] The new Java rule LinguisticNaming (java-codestyle)

Detects cases, when a method name indicates it returns a boolean (such as
isSmall()) but it doesn't. Besides method names, the rule also checks field and
variable names. It also checks, that getters return something but setters won't.
The rule has several properties with which it can be customized.
---
 src/main/resources/net/kemitix/pmd/java.xml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/main/resources/net/kemitix/pmd/java.xml b/src/main/resources/net/kemitix/pmd/java.xml
index c733932..5314bc9 100644
--- a/src/main/resources/net/kemitix/pmd/java.xml
+++ b/src/main/resources/net/kemitix/pmd/java.xml
@@ -104,6 +104,7 @@ http://pmd.sourceforge.net/ruleset/2.0.0 ">
     <rule ref="category/java/codestyle.xml/GenericsNaming"/>
     <rule ref="category/java/codestyle.xml/IfElseStmtsMustUseBraces"/>
     <rule ref="category/java/codestyle.xml/IfStmtsMustUseBraces"/>
+    <rule ref="category/java/codestyle.xml/LinguisticNaming" />
     <rule ref="category/java/codestyle.xml/LocalVariableCouldBeFinal"/>
     <rule ref="category/java/codestyle.xml/LongVariable"/>
     <rule ref="category/java/codestyle.xml/MethodArgumentCouldBeFinal"/>

From 0d06af961496d96cf566c3a783ee9828af0e26ef Mon Sep 17 00:00:00 2001
From: Paul Campbell <pcampbell@kemitix.net>
Date: Mon, 3 Sep 2018 08:58:16 +0100
Subject: [PATCH 3/3] Remove deprecated rules

The Java rules VariableNamingConventions, MIsLeadingVariableName,
SuspiciousConstantFieldName, and AvoidPrefixingMethodParameters are
now deprecated, and will be removed with version 7.0.0.
---
 src/main/resources/net/kemitix/pmd/java.xml | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/main/resources/net/kemitix/pmd/java.xml b/src/main/resources/net/kemitix/pmd/java.xml
index 5314bc9..c0cb36a 100644
--- a/src/main/resources/net/kemitix/pmd/java.xml
+++ b/src/main/resources/net/kemitix/pmd/java.xml
@@ -116,7 +116,6 @@ http://pmd.sourceforge.net/ruleset/2.0.0 ">
     <rule ref="category/java/codestyle.xml/ShortClassName"/>
     <rule ref="category/java/codestyle.xml/ShortMethodName"/>
     <rule ref="category/java/codestyle.xml/ShortVariable"/>
-    <rule ref="category/java/codestyle.xml/SuspiciousConstantFieldName"/>
     <rule ref="category/java/codestyle.xml/TooManyStaticImports"/><!-- to review -->
     <rule ref="category/java/codestyle.xml/UnnecessaryConstructor"/>
     <rule ref="category/java/codestyle.xml/UnnecessaryFullyQualifiedName"/>
@@ -125,7 +124,6 @@ http://pmd.sourceforge.net/ruleset/2.0.0 ">
     <rule ref="category/java/codestyle.xml/UnnecessaryReturn"/>
     <rule ref="category/java/codestyle.xml/UselessParentheses"/>
     <rule ref="category/java/codestyle.xml/UselessQualifiedThis"/>
-    <rule ref="category/java/codestyle.xml/VariableNamingConventions"><!-- to review --></rule>
     <rule ref="category/java/codestyle.xml/WhileLoopsMustUseBraces"/>
 
     <!-- Design -->