kemitix/mon
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Left/Right: don't use @Getter for final fields

Browse source 
QA tools want these fields to be static, for which lombok creates static getter
methods, which then don't match the specification from the `Either` interface.
This commit is contained in:
Paul Campbell 2018-07-16 22:29:46 +01:00
parent d001a3cb3b
commit a1a7ad65c2
2 changed files with 20 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/main/java/net/kemitix/mon/experimental/either/Left.java
View file

@ -21,7 +21,6 @@
package net.kemitix.mon.experimental.either; package net.kemitix.mon.experimental.either;
import lombok.Getter;
import lombok.RequiredArgsConstructor; import lombok.RequiredArgsConstructor;
import java.util.function.Consumer; import java.util.function.Consumer;
@ -37,13 +36,18 @@ import java.util.function.Function;
@RequiredArgsConstructor @RequiredArgsConstructor
class Left<L, R> implements Either<L, R> { class Left<L, R> implements Either<L, R> {
@Getter
private final boolean left = true;
@Getter
private final boolean right = false;
private final L value; private final L value;
@Override
public boolean isLeft() {
return true;
}
@Override
public boolean isRight() {
return false;
}
@Override @Override
public void match(final Consumer<L> onLeft, final Consumer<R> onRight) { public void match(final Consumer<L> onLeft, final Consumer<R> onRight) {
onLeft.accept(value); onLeft.accept(value);

16
src/main/java/net/kemitix/mon/experimental/either/Right.java
View file

@ -21,7 +21,6 @@
package net.kemitix.mon.experimental.either; package net.kemitix.mon.experimental.either;
import lombok.Getter;
import lombok.RequiredArgsConstructor; import lombok.RequiredArgsConstructor;
import java.util.function.Consumer; import java.util.function.Consumer;
@ -37,13 +36,18 @@ import java.util.function.Function;
@RequiredArgsConstructor @RequiredArgsConstructor
class Right<L, R> implements Either<L, R> { class Right<L, R> implements Either<L, R> {
@Getter
private final boolean left = false;
@Getter
private final boolean right = true;
private final R value; private final R value;
@Override
public boolean isLeft() {
return false;
}
@Override
public boolean isRight() {
return true;
}
@Override @Override
public void match(final Consumer<L> onLeft, final Consumer<R> onRight) { public void match(final Consumer<L> onLeft, final Consumer<R> onRight) {
onRight.accept(value); onRight.accept(value);