kemitix/mon
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Rename Result.maybeThen() as Result.flatMapMaybe()

Browse source
This commit is contained in:
Paul Campbell 2018-07-10 22:46:22 +01:00
parent 97e08ab4fa
commit c64284872c
3 changed files with 18 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
CHANGELOG
View file

@ -1,6 +1,10 @@
CHANGELOG
=========
0.11.0
* Rename `Result.maybeThen()` as `Result.flatMapMaybe()`
0.10.0
------

2
src/main/java/net/kemitix/mon/result/Result.java
View file

@ -129,7 +129,7 @@ public interface Result<T> extends Functor<T, Result<?>> {
* @param <R> the type of the updated Result
* @return a new Maybe within a Result
*/
static <T, R> Result<Maybe<R>> maybeThen(Result<Maybe<T>> maybeResult, Function<Maybe<T>, Result<Maybe<R>>> f) {
static <T, R> Result<Maybe<R>> flatMapMaybe(Result<Maybe<T>> maybeResult, Function<Maybe<T>, Result<Maybe<R>>> f) {
return maybeResult.flatMap(f);
}

26
src/test/java/net/kemitix/mon/ResultTest.java
View file

@ -605,24 +605,24 @@ public class ResultTest implements WithAssertions {
}
@Test
public void okayJust_whenMaybeThen_whereOkayJust_thenIsOkayJust() {
public void okayJust_whenFlatMapMaybe_whereOkayJust_thenIsOkayJust() {
//given
final Result<Maybe<Integer>> okJust = Result.ok(Maybe.just(1));
//when
final Result<Maybe<Integer>> result = Result.maybeThen(okJust, mv -> Result.ok(Maybe.just(2)));
final Result<Maybe<String>> result = Result.flatMapMaybe(okJust, maybe -> Result.ok(maybe.flatMap(v -> Maybe.just("2"))));
//then
result.match(
success -> assertThat(success.toOptional()).contains(2),
success -> assertThat(success.toOptional()).contains("2"),
error -> fail("Not an error")
);
}
@Test
public void okayJust_whenMaybeThen_whereOkayNothing_thenIsOkayNothing() {
public void okayJust_whenFlatMapMaybe_whereOkayNothing_thenIsOkayNothing() {
//given
final Result<Maybe<Integer>> okJust = Result.ok(Maybe.just(1));
//when
final Result<Maybe<Integer>> result = Result.maybeThen(okJust, v -> Result.ok(Maybe.nothing()));
final Result<Maybe<String>> result = Result.flatMapMaybe(okJust, maybe -> Result.ok(maybe.flatMap(v -> Maybe.nothing())));
//then
result.match(
success -> assertThat(success.toOptional()).isEmpty(),
@ -631,12 +631,12 @@ public class ResultTest implements WithAssertions {
}
@Test
public void okayJust_whenMaybeThen_whereError_thenIsError() {
public void okayJust_whenFlatMapMaybe_whereError_thenIsError() {
//given
final Result<Maybe<Integer>> okJust = Result.ok(Maybe.just(1));
final RuntimeException exception = new RuntimeException();
//when
final Result<Maybe<Integer>> result = Result.maybeThen(okJust, v -> Result.error(exception));
final Result<Maybe<Integer>> result = Result.flatMapMaybe(okJust, v -> Result.error(exception));
//then
result.match(
success -> fail("Not a success"),
@ -645,27 +645,27 @@ public class ResultTest implements WithAssertions {
}
@Test
public void okayNothing_whenMaybeThen_thenDoNotApply() {
public void okayNothing_whenFlatMapMaybe_thenDoNotApply() {
//given
final Result<Maybe<Integer>> okNothing = Result.ok(Maybe.nothing());
//when
final Result<Maybe<Integer>> result = Result.maybeThen(okNothing, v -> Result.ok(Maybe.just(2)));
final Result<Maybe<String>> result = Result.flatMapMaybe(okNothing, maybe -> Result.ok(maybe.flatMap(v -> Maybe.just("2"))));
//then
okNothing.match(
result.match(
success -> assertThat(success.toOptional()).isEmpty(),
error -> fail("Not an error")
);
}
@Test
public void error_whenMaybeThen_thenDoNotApply() {
public void error_whenFlatMapMaybe_thenDoNotApply() {
//given
final RuntimeException exception = new RuntimeException();
final Result<Maybe<Integer>> maybeResult = Result.error(exception);
//when
final Result<Maybe<Integer>> result = Result.maybeThen(maybeResult, v -> Result.ok(Maybe.just(2)));
final Result<Maybe<String>> result = Result.flatMapMaybe(maybeResult, maybe -> Result.ok(maybe.flatMap(v -> Maybe.just("2"))));
//then
maybeResult.match(
result.match(
success -> fail("Not a success"),
error -> assertThat(error).isSameAs(exception)
);