Commit graph

320 commits

Author SHA1 Message Date
19057140e4 Merge branch 'hotfix/4.0.1' into develop
* hotfix/4.0.1:
  Remove unused imports
  Add test for checkClasses bean
  Update CHANGELOG
  Add set-version.sh
  Remove use of @PostContruct
  Update README tile version
  Lombok should be provided
  Test should be using interface
  Upgrade kemitix-maven-tiles to 0.3.0
  Add javax.annotation-api for jdk 9 compatibility
  Upgrade lombok to 1.16.20
  version set to 4.0.1
  Add sourceDirectories to avoid scanning generated sources
2018-01-25 07:22:12 +00:00
ede3db53bf Remove unused imports 2018-01-25 06:59:09 +00:00
fd63f94a27 Add test for checkClasses bean 2018-01-25 06:55:18 +00:00
d3f86fc318 Remove use of @PostContruct 2018-01-24 21:55:52 +00:00
5e62e74593 Lombok should be provided 2018-01-24 21:55:14 +00:00
3c83b78cea Test should be using interface 2018-01-24 21:47:17 +00:00
9983997391 Upgrade kemitix-maven-tiles to 0.3.0 2018-01-24 07:06:56 +00:00
1529472940 Add javax.annotation-api for jdk 9 compatibility 2018-01-24 07:04:45 +00:00
c5d6af4ffa Upgrade lombok to 1.16.20 2018-01-24 07:04:15 +00:00
62c81bd0b3 version set to 4.0.1 2018-01-20 22:27:25 +00:00
fb354b9902 Merge branch 'hotfix/4.0.0' into develop
* hotfix/4.0.0:
  tile use tiles
  ruleset uses UTF-8 encoding
  Regressions use own checkstyle config
  Upgrade maven-checkstyle-plugin to 3.0.0
  Update checkstyle groupId/artifactId/version in support modules
  Update travis-support
  Prevent installation of support modules
  Run builder during package phase
  Add local checkstyle plugin config for builder
  Change ruleset groupId/artifactId to net.kemitix.checkstyle.ruleset
  Simplify groupId and artifactId under net.kemitix.checkstyle
  Restore Header and JavadocPackage checks
  [bug] update the ruleset files and add missing reasons for deactivated rules
  Version set to 3.4.1
2018-01-17 20:11:12 +00:00
c4b79a9831 version set to 4.1.0-SNAPSHOT 2018-01-17 20:07:09 +00:00
f9a5684ec5 Prevent installation of support modules 2018-01-17 20:05:53 +00:00
9a2297fe6d Run builder during package phase
This should help to avoid forgetting to update the ruleset and readme in future.
2018-01-17 20:05:53 +00:00
cd4afa6034 Add local checkstyle plugin config for builder
Builder can't access the current version of the tile during build, so it needs
its own checkstyle config declaration.
2018-01-17 20:05:53 +00:00
68c4ca055a Change ruleset groupId/artifactId to net.kemitix.checkstyle.ruleset
Add tile maven-tile
Update README
2018-01-17 20:05:53 +00:00
8573a0374a Simplify groupId and artifactId under net.kemitix.checkstyle 2018-01-17 20:04:02 +00:00
64f1308004 Restore Header and JavadocPackage checks 2018-01-17 20:00:26 +00:00
091e4f139e [bug] update the ruleset files and add missing reasons for deactivated rules 2018-01-17 20:00:26 +00:00
7ae51727a2 Upgrade maven-checkstyle-plugin to 3.0.0 2018-01-17 19:10:55 +00:00
14a038c9f3 Update checkstyle groupId/artifactId/version in support modules 2018-01-17 18:41:42 +00:00
09f1f3eb5f Prevent installation of support modules 2018-01-16 22:36:27 +00:00
06b14df6cd Run builder during package phase
This should help to avoid forgetting to update the ruleset and readme in future.
2018-01-16 22:28:07 +00:00
bbeae5b56c Add local checkstyle plugin config for builder
Builder can't access the current version of the tile during build, so it needs
its own checkstyle config declaration.
2018-01-16 22:24:23 +00:00
faae9e9afa Change ruleset groupId/artifactId to net.kemitix.checkstyle.ruleset
Add tile maven-tile
Update README
2018-01-16 22:23:33 +00:00
1770e5aff1 Simplify groupId and artifactId under net.kemitix.checkstyle 2018-01-16 17:38:36 +00:00
5b5c0673a0 Restore Header and JavadocPackage checks 2018-01-14 19:13:34 +00:00
54fa8f0be4 [bug] update the ruleset files and add missing reasons for deactivated rules 2018-01-14 19:13:13 +00:00
5a8cf1b884 Version set to 3.4.1 2018-01-14 18:46:51 +00:00
a9d458355f Version set to 3.5.0-SNAPSHOT 2018-01-07 20:20:42 +00:00
0a03122f80 Upgrade kemitix-maven-tiles to 0.2.0 2018-01-07 20:06:08 +00:00
56d36da8c9 version set to 3.4.0 2018-01-07 20:01:54 +00:00
e8452d8c19 Make modules independant of root pom
* Revert kemitix-maven-tiles to 0.1.1 until release
* Move pom details from root to ruleset pom
2018-01-07 19:29:36 +00:00
309ace6c76 Specify lombok version in parent pom 2018-01-06 19:45:18 +00:00
c8c6b1ae57 Disable JavadocPackage check 2018-01-06 08:21:58 +00:00
84013ee1ae Disable AvoidStaticImport check 2018-01-06 08:18:39 +00:00
e18668dea7 Disable AvoidStarImport check 2018-01-06 08:18:23 +00:00
f20517a8e7 Disable Header check 2018-01-06 08:18:05 +00:00
fa9cc33a4d Remove requirement for @auther in Type Javadoc 2018-01-06 08:17:38 +00:00
87358bfe92 Update builder tests 2018-01-05 22:22:18 +00:00
372b8e0f3c Use tiles in builder 2018-01-03 20:35:06 +00:00
020635841a Remove kemitix-parent from pom ancestry 2018-01-03 20:27:21 +00:00
4328e49c7f version: set to 3.4.0-SNAPSHOT 2017-07-13 15:55:00 +01:00
ac7c15694b version: set to 3.3.0 2017-07-13 15:50:06 +01:00
90e3652e6e {builder,plugin}:*Test: replace deprecated org.mockito.Matchers.* imports 2017-07-13 14:19:39 +01:00
7b144fdb0a AvoidDefaultSerializableInInnerClasses: enable rule 2017-07-13 11:57:44 +01:00
3fe3d16d42 FinalizeImplementation: enable rule 2017-07-05 15:30:33 +01:00
69ee78e50e WhiteSpaceBeforeArrayInitializer: enable rule 2017-07-04 12:31:37 +01:00
55ff66d98b EmptyPublicCtorInClass: enable rule 2017-07-04 12:25:30 +01:00
ff2e4b9c95 builder: move dependency management to parent pom 2017-06-17 08:29:05 +01:00
ecf22ade2f version: set to 3.3.0-SNAPSHOT
remove redundant version elements in sub-module poms as they will inherit from the parent pom
2017-06-12 10:12:48 +01:00
f5f69a006f version: set to 3.2.0 2017-06-12 09:48:06 +01:00
90901766f5 builder: pom.xml: use project parent pom 2017-06-09 19:43:43 +01:00
f5eddc088f builder: pom.xml: upgrade kemitix-parent to 3.0.0
* Specify Spring Platform as Brussels-SR2
2017-06-09 19:15:10 +01:00
de597e0164 pom.xml: normalise maven pom names 2017-06-02 19:27:14 +01:00
2b8533273f Add level 0 Disabled 2017-05-31 12:10:06 +01:00
b28771989a version: set to 3.2.0-SNAPSHOT 2017-05-30 15:27:29 +01:00
4cc70343be builder: ExplicitInitilization only applies to object references 2017-05-30 15:01:05 +01:00
9e657b36ec version: set to 3.1.0 2017-05-30 14:36:46 +01:00
f189fb3b84 builder: DefaultPackageScannerTest: make classPath local variable 2017-05-30 12:44:33 +01:00
1b318253d2 builder: BuilderConfigurationTest: added 2017-05-30 12:43:34 +01:00
0503156bd0 Merge branch 'develop' into upgrade-checkstyle
* develop:
  wercker.yml: rewritten
  wercker.yml: added
  travis-ci: remove defensive checks
  shippable.yml: added
  travis-ci: only deploy from Travis-CI
  KCR37+38: MoveVariableInsideIf: avoid unused private methods
  KCR39: regressions: MoveVariableInsideIf: method(): use parameter
  KCR38: regressions: MoveVariableInsideIf: valid(): use explicit scope
  KCR37: regressions: MoveVariableInsideIf: invalid(): use explicit scope
  KXR36: plugin: DefaultCheckstyleExecutorTest: artifactFile: make local variable
  builder: ReadmeWriterTest: templateProperties: make local variable
  KCR35: builder: ReadmeWriterTest: fragments: make local variable
  KCR34: builder: ReadmeWriterTest: template: make local variable
  KCR33: builder: ReadmeWriterTest: outputProperties: make local
  KCR31: builder: DefaultRuleReadmeLoaderTest: make field local
  KCr30: CheckstyleWriterTest: checkstyleTemplate: make field local variable
  KCR28: builder: remove empty test class
  builder: CheckstyleWriter: avoid throwing raw exception types
2017-05-30 12:38:38 +01:00
2e8e26c351 builder: refactored and improved test coverage 2017-05-30 12:32:29 +01:00
a0ca4958fc builder: use fully qualified classnames in XML files
In Checkstyle 7.8 a new mechanisim is used to lookup rules by
name. This new method causes an exception to be thrown is there are
more than one classes found that match the rule name.

The solution is to use fully qualified class names in the module tag
in the XML ruleset files.
2017-05-29 23:55:42 +01:00
701b64e2c6 builder: ReadmeWriterTest: templateProperties: make local variable 2017-05-29 13:27:24 +01:00
74690d8cdf KCR35: builder: ReadmeWriterTest: fragments: make local variable 2017-05-29 13:25:50 +01:00
d754fdc0a3 KCR34: builder: ReadmeWriterTest: template: make local variable 2017-05-29 13:23:37 +01:00
c4f302d9e5 KCR33: builder: ReadmeWriterTest: outputProperties: make local
Fixes #33
2017-05-29 13:22:57 +01:00
b04d131245 Merge pull request #43 from kemitix/kcr-31-builder-defaultrulereadmeloadertest-fragment-localvariable
KCR31: builder: DefaultRuleReadmeLoaderTest: make field local
2017-05-29 13:16:35 +01:00
27806fb2a2 KCR31: builder: DefaultRuleReadmeLoaderTest: make field local
* fragment (Fixes  #31)
* templateProperties (Fixes #32)
2017-05-29 12:27:40 +01:00
f7867283ff KCr30: CheckstyleWriterTest: checkstyleTemplate: make field local variable 2017-05-29 12:24:51 +01:00
82999a87fc Merge branch 'develop' into kcr-28-avoid-throwing-raw-exception-types
* develop:
  KCR29: travis-ci: detect Travis-CI
  KCR29: travis-ci: dump $TRAVIS and other env
  KCR29: travis-ci: should only submit coverage report from Travis-CI
  KCR29: builder: Rule: sortByName(): use explicit scoping
2017-05-29 12:11:08 +01:00
9d2895269d KCR29: builder: Rule: sortByName(): use explicit scoping 2017-05-29 11:31:13 +01:00
9ac59206a0 KCR28: builder: remove empty test class 2017-05-29 11:26:24 +01:00
81768ff9f9 builder: CheckstyleWriter: avoid throwing raw exception types
Instead of throwing RuntimeException or IOException, throw
CheckstyleWriterException or TemplateNotFoundException.
2017-05-29 11:23:48 +01:00
4a0ee1de46 ruleset: MoveVariableInsideIf: enabled for 4-tweaks and above 2017-05-28 19:56:43 +01:00
6072613b44 pom.xml: upgrade sevntu to 1.24.0
* Fixes bug in ForbidWildcardAsReturnType which is now enabled again
* Additional pluginRepositories config is no longer required
2017-05-28 19:52:24 +01:00
df9926c428 Merge branch 'master' into develop
* master:
  travis--ci: update key to match passphrase
  travis--ci: batch import signing key
  travis-ci: replace signing key to match passphrase
  .travis.yml: CI_DEPLOY_GPG_PASSPHRASE (4/4)
  .travis.yml: CI_DEPLOY_GPG_KEYNAME (3/4)
  .travis.yml: CI_DEPLOY_PASSWORD (2/4)
  .travis.yml: replace encrypted data (1/4)
  travis-ci: update location of travis-settings.xml
  travis-ci: use a shell-safe password
  travis-ci: make shell scripts executable (again)
  travis-ci: remove comments
  travis-ci: updated and add encrypted gpg credentials
  pom.xml: version set to 2.1.2
2017-05-28 18:06:02 +01:00
2706045dfb travis-ci: updated and add encrypted gpg credentials 2017-05-28 14:54:23 +01:00
c4be689fcc version: set to 3.0.1 2017-05-27 20:45:11 +01:00
2584ed4bb3 version: set to 3.1.0-SNAPSHOT 2017-05-27 16:48:15 +01:00
5af558544e pom.xml: version set to 3.0.0 2017-05-27 16:45:22 +01:00
c14c9ea8ca KCR22: builder: sort rules alphabetically 2017-05-27 14:04:19 +01:00
1b27a84bd6 version: set to 3.0.0-SNAPSHOT 2017-05-27 08:58:11 +01:00
d1d174d5a7 API Change: plugin: level is specified as a configuration parameter
* merge all level-based goals into a single 'check' goal
* specify the level to apply as a configuration parameter
* add remaining unit tests for plugin
2017-05-27 08:53:56 +01:00
6f9f07709f README.md,application.yml: fix typo
ArrayTrailingCommand and FinalLocalVariable had typo in level (TWEAK
when it should have been TWEAKS)
2017-05-26 09:17:29 +01:00
7c774a5057 {builder,plugin}: pom.xml: upgrades
* kemitix-parent: 2.4.0 -> 2.8.0
* spring-boot: 1.5.1 -> 1.5.3
* lombok: 1.16.12 -> 1.16.16 (reverting to kemitix-parent version)
* assertj: 3.6.2 -> 3.8.0
* maven: 3.3.9 -> 3.5.0
* mojo-executor: 2.2.0 -> 2.3.0
2017-05-25 16:28:35 +01:00
db496848cc pom.xml: version set to 2.4.0-SNAPSHOT 2017-04-02 16:16:50 +01:00
2004fc60d6 pom.xml: version set to 2.3.0 2017-04-02 16:14:23 +01:00
42985446a0 ForbidWildcardAsReturnType: disabled
When used with org.immutables:value, this check will kill the
Checkstyle process by throwing a NullPointerException.
2017-04-02 14:17:57 +01:00
8b1627df0b LICENSE.txt: updated 2017-04-02 13:45:59 +01:00
efa9b98378 pom.xml: version set to 2.3.0-SNAPSHOT 2017-03-11 17:44:34 +00:00
cc5d8f7ed1 pom.xml: version set to 2.2.0 2017-03-11 17:42:31 +00:00
f9ee73f148 RegexpOnFilename: Add a new rule to detect if there are any sync conflict files
Fails if there there are any Syncthing or Dropbox sync conflicts on any *.java file.
2017-03-11 16:55:34 +00:00
0e2f762cd0 builder: pom.xml: remove dependency on plugin
The checkstyle plugin wouldn't have been installed yet.
2017-02-26 17:42:08 +00:00
eebe90b44b builder: pom.xml: rename map-builder property for consistency 2017-02-26 17:41:24 +00:00
7134a476a2 builder: pom.xml: kemitix-spring-parent replaced with kemitix-parent:2.4.0 2017-02-26 17:40:34 +00:00
4de68a84ce builder:CheckstyleWriterTest: use system's file separator 2017-02-08 19:50:54 +00:00
df4c951142 builder:CheckstyleWriter: use system's line separator 2017-02-08 19:40:53 +00:00
829cc5dff6 pom.xml: version set to 2.2.0-SNAPSHOT 2017-02-08 12:30:18 +00:00
961eb2c1db pom.xml: version set to 2.1.0 2017-02-08 12:26:55 +00:00
5fc556aaf2 builder:pom.xml: upgrade dependencies
* spring-boot 1.5.1
* assertj 3.6.2
* mapstream 2.3.5
2017-02-08 11:29:48 +00:00
7e2a0790ff pom.xml: version set to 2.1.0-SNAPSHOT 2017-01-14 17:53:26 +00:00
c5d0bda1ca pom.xml: version set to 2.0.0 2017-01-14 17:47:14 +00:00
67557955cc plugin: provide goals for each ruleset level 2017-01-14 17:04:18 +00:00
dc639da079 plugin: added 2017-01-13 22:53:01 +00:00
c254afcca7 builder:pom.xml: clean up 2017-01-13 22:53:01 +00:00
f39f1a88db builder: configure coveralls coverage reporting 2017-01-10 20:34:23 +00:00
e5c22f47e0 builder:DefaultRuleReadmeLoaderTest: added 2017-01-10 20:29:33 +00:00
2b08488e38 builder:ReadmeFragmentNotFoundException: added 2017-01-10 20:29:04 +00:00
ced2def664 builder: DefaultRuleReadmeLoader: don't inject blank line above each rule 2017-01-10 20:10:57 +00:00
1333df0c98 builder:CheckstyleWriterTest: use lombok's val 2017-01-10 19:59:36 +00:00
d342495fbd builder:{Checkstyle,Readme}WriterTest: use @Rule TemporaryFolder 2017-01-10 19:59:14 +00:00
8696fb10cd README.md: update usage example 2017-01-09 08:31:56 +00:00
b414a8e602 builder:RuleParentTest: added 2017-01-07 18:20:55 +00:00
c73a23f838 builder:ReadmeWriterTest: added 2017-01-07 18:16:19 +00:00
53586a7ffd builder:RuleTest: added
Rule:

* remove redundant @ToString
* prevent creation of setProperties()
2017-01-07 18:16:02 +00:00
9b3f0869ea builder:RuleSourceTest: added
Replace final delimiter in RuleSource.
2017-01-07 12:08:38 +00:00
a31b2d81d3 builder:RulesPropertiesTest: added
Remove unused setter on RulesProperties.
2017-01-07 11:56:24 +00:00
e6b1779f72 builder:OutputProperties: added 2017-01-07 11:52:19 +00:00
a90751a237 builder:TemplatePropertiesTest: added 2017-01-07 11:47:56 +00:00
419817f25f builder:DefaultReadmeIndexBuilderTest: added 2017-01-07 11:41:35 +00:00
4989f21331 builder:DefaultReadmeIndexBuilder: move table header to README-template.md 2017-01-07 11:27:38 +00:00
9f979955f8 builder:pom.xml: use kemitix-spring-parent 2017-01-06 22:37:24 +00:00
c027c372d8 builder:CheckstyleWriter: use UTF-8 encoding to load XML template 2017-01-06 22:36:52 +00:00
be2e92bdb6 builder:CheckstyleWriterTest: added 2017-01-06 22:10:40 +00:00
13e813b558 builder:CheckstyeWriter: restructure and write file with default options
Flip if block inside-out and add some logging
2017-01-06 22:10:27 +00:00
ab0a95e395 builder:RulesProperties: initialise rules list 2017-01-06 21:56:37 +00:00
abb8e8e5c0 builder:pom.xml: add test dependencies 2017-01-06 21:50:00 +00:00
9e26504c67 builder: meet level 5 complexity
* DefaultReadmeIndexBuilder: final build() method
* DefaultReadmeIndexBuilder: avoid inline conditionals
* DefaultRuleReadmeLoader: reduce returns in load method
2017-01-06 16:38:41 +00:00
e2069b8d0d builder: meet level 4 tweaks
* Add missing Rule SuppressWarningsFilter
* Suppress HideUtilityClassConstructor on main class
2017-01-06 16:24:22 +00:00
9eb00f5a16 builder: meet level 3 javadoc 2017-01-06 16:00:08 +00:00
c88b820c5f builder: meet level 2 naming
* remove duplicate string literal
2017-01-06 15:59:44 +00:00
a804775f1a builder: fix author tags 2017-01-06 15:50:50 +00:00
7e9b17f1cc builder:pom.xml: eat out own dog food - level 1 layout
* Add license header to source files
* fix long line
2017-01-06 15:49:11 +00:00
a83cc94dd8 builder:checkstyle-template: fix name of TreeWalker module 2017-01-06 15:32:29 +00:00
8738afea8b README.md: update example usage 2017-01-06 15:31:14 +00:00
a5d2a300f9 LICENSE.*: rename from md to txt and copy to builder 2017-01-06 15:30:33 +00:00
affe65263a README.md: fix links to rules
Having the level in the heading meant that the anchor link was modified,
breaking the links.
2017-01-06 15:12:10 +00:00
c46668d1f1 builder:ReadmeIndexBuilder: refactored out from ReadmeWriter 2017-01-06 14:50:45 +00:00
f6ee87e6dc README.md: replace rule index list with a table 2017-01-06 13:23:03 +00:00
349c995f66 README.md: include rule level in each rule's documentation 2017-01-05 23:54:44 +00:00
a2b64abe77 README.md: include rule level in index 2017-01-05 23:51:59 +00:00
1fa27f2071 builder:DefaultRuleReadmeLoader: show 'reason' instead for disabled rules 2017-01-05 23:41:45 +00:00
b70b7c4a5a builder:application.yml: added details of disabled rules
Includes the reason they are disabled.
2017-01-05 23:33:11 +00:00
b37616ce70 builder:readme:README.*.md: remove redundant fragments 2017-01-05 22:14:07 +00:00
8eeb0a3cec builder:ReadmeWriter: added
Doesn't support including disabled rules yet.
2017-01-05 16:57:32 +00:00
92b8dabd93 builder:Rule:insuppressible: add flag for rules that can't be suppressed 2017-01-05 16:57:32 +00:00
6e9ac736e9 builder:README-template.md: added 2017-01-05 16:32:30 +00:00
fb02dc5f88 builder:RuleReadmeLoader: added rule documentation fragment loader 2017-01-05 16:31:27 +00:00
44603084fa builder:CheckstyleWriter: get template location from TemplateProperties 2017-01-05 16:20:22 +00:00
2defbd6be3 builder:Rule: don't store body in Rule 2017-01-05 16:19:52 +00:00
0a99044dcc builder:OutputProperties: add path to README.md 2017-01-05 16:19:34 +00:00
e7f30c760b builder:TemplateProperties: added 2017-01-05 16:18:59 +00:00
d2a9f6ffa0 builder:README.header.md: update example versions 2017-01-05 09:48:04 +00:00
2e1404ffa4 builder:README.header.md: update with levels 2017-01-05 09:47:31 +00:00
cdfeccb98b builder:CheckstyleWriter: create xml files for each rule level 2017-01-05 07:02:33 +00:00
f2eb247d8b builder:checkstyle-template.xml: add String.format template for xml files 2017-01-05 07:01:57 +00:00
95bc4064ae builder:pom.xml: add dependency on mapstream 2.3.4 2017-01-05 07:01:27 +00:00
23d1a49592 builder:Application: remove rule lister 2017-01-05 06:59:07 +00:00
f57fcfe3f6 builder:OutputProperties: restructured output file specification
Map the filenames from each of the RuleLevel values.
2017-01-05 06:58:52 +00:00
ac3f7b28ab builder:application.yml: assign missing levels to rules 2017-01-05 06:43:08 +00:00
7bd6dc038b builder:Application:add EnableConfifurationProperties
Remove unused @Slf4j annotation
2017-01-04 22:26:17 +00:00
aa6bb84396 builder:RulesProperties: added javadoc 2017-01-04 22:25:32 +00:00
68c74e2d08 builder:Rule: add javadoc 2017-01-04 22:25:19 +00:00
d52b630db5 builder:Application: list rules on startup 2017-01-04 20:45:18 +00:00
81bb3c02c4 builder:Rule{sProperties}: load properly 2017-01-04 20:44:49 +00:00
4a7a2871ac builder:application.yml:AtClauseOrder: protect '@' by wrapping properties 2017-01-04 20:36:10 +00:00
9b8fea775c builder/pom.xml: configure dependencies 2017-01-04 20:30:20 +00:00
a88c76f519 First pass as splitting distribution from builder 2017-01-04 20:29:26 +00:00